Skip to content

[JsonPath] Use git submodules for JsonPath compliance test suite #62761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
alexandre-daubois wants to merge 1 commit into
base: 7.3
Choose a base branch
from
Open

[JsonPath] Use git submodules for JsonPath compliance test suite #62761

alexandre-daubois wants to merge 1 commit into from
+35 −13,206

Conversation

@alexandre-daubois
Copy link
Member

@alexandre-daubois alexandre-daubois commented Dec 12, 2025

Q A
Branch? 7.3
Bug fix? yes
New feature? no
Deprecations? no
Issues -
License MIT

I'd suggest considering this one as a bug fix so all supported branches benefit from this.

@carsonbot carsonbot added this to the 7.3 milestone Dec 12, 2025
stof
stof reviewed Dec 12, 2025
View reviewed changes
src/Symfony/Component/JsonPath/Tests/JsonPathComplianceTestSuiteTest.php
public static function complianceCaseProvider(): iterable
{
$data = json_decode(file_get_contents(__DIR__.'/Fixtures/cts.json'), false, flags: \JSON_THROW_ON_ERROR);
$data = json_decode(file_get_contents(self::COMPLIANCE_TEST_SUITE_FILE), false, flags: \JSON_THROW_ON_ERROR);
Copy link
Member

@stof stof Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't this break when running tests without the submodules installed ? Data providers are run before the setUp method.

Copy link
Member Author

@alexandre-daubois alexandre-daubois Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't understand how I've been able to skip all cases locally with this code. But anyway, I took the same approach as #62642

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Dec 12, 2025

instead of gitmodules, can't we use composer? I think we do so already for the intl component (or emoji? I don't remember)

@stof
Copy link
Member

stof commented Dec 12, 2025 •
edited
Loading

We could indeed use a package repository for composer. This is what I do for the sass-spec repo in https://github.com/scssphp/scssphp/ (and the setup could be simplified to avoid duplicating the commit reference btw not yet actually: composer/composer#12678).

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Dec 13, 2025

I was thinking about the composer.json in this directory:
https://github.com/symfony/symfony/tree/8.1/src/Symfony/Component/Emoji/Resources/bin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stof stof stof left review comments

Assignees

No one assigned

Labels

Bug JsonPath Status: Needs Review

Projects

None yet

Milestone

7.3

Development

Successfully merging this pull request may close these issues.

4 participants

@alexandre-daubois @nicolas-grekas @stof @carsonbot