Skip to content

[Yaml] Add yaml test suite #62642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
maxbeckers wants to merge 1 commit into
base: 8.1
Choose a base branch
from
Open

[Yaml] Add yaml test suite #62642

maxbeckers wants to merge 1 commit into from
+326 −0

Conversation

@maxbeckers
Copy link
Contributor

@maxbeckers maxbeckers commented Dec 4, 2025 •
edited
Loading

Q A
Branch? 8.1
Bug fix? no
New feature? no
Deprecations? no
Issues Fix #62450
License MIT

Add the https://github.com/yaml/yaml-test-suite for testing the yaml componnent.

  • Embedding the test-suite as a submodule.
  • Skipping all failing tests

The submodule checkout should also be configured then in the yaml component pipeline if needed.

@maxbeckers maxbeckers requested a review from xabbuh as a code owner December 4, 2025 08:38
@carsonbot carsonbot added this to the 8.1 milestone Dec 4, 2025
@carsonbot carsonbot changed the title [YAML] Add yaml test suite [Yaml] Add yaml test suite Dec 4, 2025
@stof
Copy link
Member

stof commented Dec 4, 2025

  • run make -C tests/yaml-test-suite data to prepare the testsuite.

this should not be needed. Use the data branch of the testsuite repo instead.

stof
stof reviewed Dec 4, 2025
View reviewed changes
@maxbeckers maxbeckers force-pushed the patch-62450 branch 2 times, most recently from cdb466f to e1847e8 Compare December 4, 2025 10:20
derrabus
derrabus reviewed Dec 4, 2025
View reviewed changes
derrabus
derrabus reviewed Dec 4, 2025
View reviewed changes
stof
stof reviewed Dec 4, 2025
View reviewed changes
@maxbeckers maxbeckers force-pushed the patch-62450 branch 6 times, most recently from 8047bfc to b5d9c5c Compare December 4, 2025 12:28
@maxbeckers
Copy link
Contributor Author

maxbeckers commented Dec 4, 2025

Thanks @stof and @derrabus for your helpful input! Now i have a solution where the tests are also running without the submodule. To adjust the pipelines i dont have the permission.

@stof
Copy link
Member

stof commented Dec 4, 2025

  • Add to the pipeline to checkout the submodule in the main repo => missing permissions to change that

which permission are you missing ? You can update the .github/workflows/ files

@maxbeckers
Copy link
Contributor Author

maxbeckers commented Dec 4, 2025

When i want to push a change on .github/workflows/ i get a permission denied. But might be a problem on my side then.

@derrabus
Copy link
Member

derrabus commented Dec 4, 2025

Weird. As long as you're pusing to your fork and not the original repository, you should not have permission problems. 🤔

@maxbeckers
Copy link
Contributor Author

maxbeckers commented Dec 4, 2025 •
edited
Loading

TIL: Was on me ... had this remote with https and not ssh ... for https tokens it's by default declined to change the workflows.

Spomky
Spomky reviewed Dec 4, 2025
View reviewed changes
stof
stof reviewed Dec 4, 2025
View reviewed changes
@mtarld mtarld mentioned this pull request Dec 8, 2025
Merged
@alexandre-daubois alexandre-daubois mentioned this pull request Dec 12, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stof stof stof left review comments

@Spomky Spomky Spomky left review comments

@derrabus derrabus derrabus left review comments

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

Assignees

No one assigned

Labels

Status: Needs Review Yaml

Projects

None yet

Milestone

8.1

Development

Successfully merging this pull request may close these issues.

[Yaml] run the official yaml testsuite with our parser

5 participants

@maxbeckers @stof @derrabus @Spomky @carsonbot