[DependencyInjection] Call default index method when index is not provided by tag #62393
+206
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoeunes
force-pushed
the
di-trait-default-index-lookup-7.3
branch
3 times, most recently
from
637ba9d to
23d25c8
Compare
yoeunes
changed the title
nicolas-grekas
force-pushed
the
di-trait-default-index-lookup-7.3
branch
from
23d25c8 to
66ca601
Compare
nicolas-grekas
approved these changes
Nov 14, 2025
Member
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
I've updated the code to make it closer to how it was before #62329
This helps with merging fixes up and also reducing the risk of unattended regressions.
Member
|
Thank you @yoeunes. |
carsonbot
changed the title
Contributor
|
Can confirm it fixes my issue. #62374 (7.3-dev works, think 7.4-dev fails as not yet backmerged) Thx 👍 |
Contributor
|
Same here 👍 Thanks @yoeunes @nicolas-grekas |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where
PriorityTaggedServiceTraitwould call thedefaultIndexMethod(likegetDefaultName()) even when:This caused an
InvalidArgumentExceptionfor services with a non-static method matching thedefaultIndexMethodname.The logic is now corrected to only call the
defaultIndexMethodas a fallback when an index is needed but not provided by the tag.