[DependencyInjection] Fix merging explicit tags and #[AsTaggedItem] #62329
+87
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
commented
Nov 6, 2025
| $indexAttribute ?? '' => $attribute->index, | ||
| ]; | ||
| if (null === $defaultPriority) { | ||
| $defaultPriority = $attribute->priority ?? 0; |
Member
Author
There was a problem hiding this comment.
only the first php-attribute can define a default priority and default index
and defaults defined by this first php-attribute have lower priority than defaults defined by static methods (getDefaultName et al.)
Note that we'd better deprecate static methods for defaults. php-attributes are cleaner IMHO. For 8.1 I suppose.
nicolas-grekas
force-pushed
the
di-fix-multi-tagged-item
branch
3 times, most recently
from
f29141d to
074c005
Compare
nicolas-grekas
force-pushed
the
di-fix-multi-tagged-item
branch
2 times, most recently
from
811c361 to
f7e67db
Compare
nicolas-grekas
force-pushed
the
di-fix-multi-tagged-item
branch
from
f7e67db to
e31b192
Compare
nicolas-grekas
commented
Nov 7, 2025
Member
Author
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
PR updated, no reordering anymore, which means no behavior change when not using multiple AsTaggeditem.
alexandre-daubois
approved these changes
Nov 10, 2025
nicolas-grekas
added a commit
that referenced
this pull request
Nov 24, 2025
This PR was merged into the 7.3 branch. Discussion ---------- [DependencyInjection] Remove unused variable | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT This variable became unused after #62329. Commits ------- f75f12f [DependencyInjection] Remove unused variable
Merged
GromNaN
added a commit
to GromNaN/monolog-bundle
that referenced
this pull request
Dec 7, 2025
Workaround a bug introduced in symfony/symfony#62329
GromNaN
changed the title
GromNaN
added a commit
to symfony/monolog-bundle
that referenced
this pull request
Dec 7, 2025
This PR was merged into the 3.x branch. Discussion ---------- Fix tags list to use consecutive keys | Q | A | ------------- | --- | Branch? | 3.x | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - | License | MIT Workaround a bug introduced in symfony/symfony#62329 The Symfony code incorrectly assumes that the tags array is a list. But we use `array_filter` which leaves gaps in the array keys. Fixed here by using `array_values` to reset the keys. Fix [failing job](https://github.com/symfony/monolog-bundle/actions/runs/19731209625/job/56532483316): ``` There were 3 errors: 1) Symfony\Bundle\MonologBundle\Tests\DependencyInjection\Compiler\AddProcessorsPassTest::testEmptyTagsAreIgnoredWhenNonEmptyArePresent with data set "with app channel" (array(array(), array('app')), array(array('useMicrosecondTimestamps', array('%monolog.use_microseconds%')), array('pushProcessor', array(Symfony\Component\DependencyInjection\Reference Object (...)))), array()) Undefined array key 0 /home/runner/work/monolog-bundle/monolog-bundle/vendor/symfony/dependency-injection/Compiler/PriorityTaggedServiceTrait.php:86 /home/runner/work/monolog-bundle/monolog-bundle/src/DependencyInjection/Compiler/AddProcessorsPass.php:55 /home/runner/work/monolog-bundle/monolog-bundle/vendor/symfony/dependency-injection/Compiler/Compiler.php:73 /home/runner/work/monolog-bundle/monolog-bundle/vendor/symfony/dependency-injection/ContainerBuilder.php:820 /home/runner/work/monolog-bundle/monolog-bundle/tests/DependencyInjection/Compiler/AddProcessorsPassTest.php:119 2) Symfony\Bundle\MonologBundle\Tests\DependencyInjection\Compiler\AddProcessorsPassTest::testEmptyTagsAreIgnoredWhenNonEmptyArePresent with data set "with my_channel channel" (array(array(), array('my_channel')), array(array('useMicrosecondTimestamps', array('%monolog.use_microseconds%'))), array(array('pushProcessor', array(Symfony\Component\DependencyInjection\Reference Object (...))))) Undefined array key 0 /home/runner/work/monolog-bundle/monolog-bundle/vendor/symfony/dependency-injection/Compiler/PriorityTaggedServiceTrait.php:86 /home/runner/work/monolog-bundle/monolog-bundle/src/DependencyInjection/Compiler/AddProcessorsPass.php:55 /home/runner/work/monolog-bundle/monolog-bundle/vendor/symfony/dependency-injection/Compiler/Compiler.php:73 /home/runner/work/monolog-bundle/monolog-bundle/vendor/symfony/dependency-injection/ContainerBuilder.php:820 /home/runner/work/monolog-bundle/monolog-bundle/tests/DependencyInjection/Compiler/AddProcessorsPassTest.php:119 3) Symfony\Bundle\MonologBundle\Tests\DependencyInjection\Compiler\AddProcessorsPassTest::testEmptyTagsAreIgnoredWhenNonEmptyArePresent with data set "with method and no channel" (array(array(), array('foo')), array(array('useMicrosecondTimestamps', array('%monolog.use_microseconds%')), array('pushProcessor', array(array(Symfony\Component\DependencyInjection\Reference Object (...), 'foo')))), array(array('pushProcessor', array(array(Symfony\Component\DependencyInjection\Reference Object (...), 'foo'))))) Undefined array key 0 /home/runner/work/monolog-bundle/monolog-bundle/vendor/symfony/dependency-injection/Compiler/PriorityTaggedServiceTrait.php:86 /home/runner/work/monolog-bundle/monolog-bundle/src/DependencyInjection/Compiler/AddProcessorsPass.php:55 /home/runner/work/monolog-bundle/monolog-bundle/vendor/symfony/dependency-injection/Compiler/Compiler.php:73 /home/runner/work/monolog-bundle/monolog-bundle/vendor/symfony/dependency-injection/ContainerBuilder.php:820 /home/runner/work/monolog-bundle/monolog-bundle/tests/DependencyInjection/Compiler/AddProcessorsPassTest.php:119 ``` Commits ------- 2127520 Fix tags must be a list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of #62327