Hi @yoeunes,

From what I understand, this looks more like an enhancement of the existing behaviour rather than a bug fix. Is that correct?
If it is indeed a bug fix, it should probably target 6.4 instead of 7.4.

Thanks!

Hi @Spomky, I consider this a bug fix because the current implementation incorrectly overwrites header items (e.g., text/plain;format=flowed (q=1.0) is lost if text/plain;format=fixed (q=0.4) is also present) which breaks content negotiation

If it's confirmed as a bug fix, should I rebase this onto 6.4 instead? Let me know your thoughts or if more details are needed

Hi @andesk, I'm consolidating my responses to your comments here to keep the thread tidy.

Thanks for the detailed review. I've pushed a full refactor that applies your suggestions, makes the code more readable, and adds explanatory comments.

Regarding case-insensitivity, you are correct. I'm now normalizing parameter names using strtolower() when building the canonical key. This aligns with RFC 9110 (Section 5.6.6) and correctly handles duplicates (e.g., Charset vs charset).
https://www.rfc-editor.org/rfc/rfc9110.html#section-5.6.6

The PR should be ready for another look. Thanks!

Hi @derrabus, thank you for your review and feedback!

I've just pushed an update to add the requested tests for Request::getAcceptableContentTypes() and Request::getPreferredFormat(), covering scenarios with parameters, quality sorting, wildcards, case-insensitivity

Let me know if anything else is needed.

Thank you @yoeunes.

This fails on 7.4, with some implicit dependency:

• fail: ./phpunit src/Symfony/Component/HttpFoundation/
• pass: ./phpunit src/Symfony/Component/HttpFoundation/ --filter testGetPreferredFormatRfc9110

We missed something.

Could you please have a look @yoeunes?

Not related to the failure, but this would be nicer than an array_map:

--- a/src/Symfony/Component/HttpFoundation/AcceptHeader.php
+++ b/src/Symfony/Component/HttpFoundation/AcceptHeader.php
@@ -48,16 +48,19 @@ class AcceptHeader
     {
         $parts = HeaderUtils::split($headerValue ?? '', ',;=');

-        return new self(array_map(function ($subParts) {
-            static $index = 0;
+        $items = [];
+        $index = 0;
+        foreach ($parts as $subParts) {
             $part = array_shift($subParts);
             $attributes = HeaderUtils::combine($subParts);

             $item = new AcceptHeaderItem($part[0], $attributes);
             $item->setIndex($index++);

-            return $item;
-        }, $parts));
+            $items[] = $item;
+        }
+
+        return new self($items);
     }

FYI I'm having a look at my own previous comment.