Skip to content

[HttpFoundation] Fix RequestTest insulation #62376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicolas-grekas merged 1 commit into from
Nov 13, 2025
Merged

[HttpFoundation] Fix RequestTest insulation #62376

nicolas-grekas merged 1 commit into from
Nov 13, 2025
+15 −15

Conversation

@nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Nov 13, 2025

Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
Issues -
License MIT

Missing insulation is how we wrote bad tests in 7.4
Also addressing my patch proposal at
#62287 (comment)

@carsonbot carsonbot added this to the 6.4 milestone Nov 13, 2025
@nicolas-grekas nicolas-grekas merged commit 562515b into symfony:6.4 Nov 13, 2025
9 of 10 checks passed
@nicolas-grekas nicolas-grekas mentioned this pull request Nov 13, 2025
Merged
nicolas-grekas added a commit that referenced this pull request Nov 13, 2025
@nicolas-grekas
minor #62379 [HttpFoundation] Fix tests (nicolas-grekas)
9e25b7b 
This PR was merged into the 7.4 branch.

Discussion
----------

[HttpFoundation] Fix tests

| Q             | A
| ------------- | ---
| Branch?       | 7.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

Spotted after #62376

Commits
-------

a9b53e9 [HttpFoundation] Fix tests
@nicolas-grekas nicolas-grekas deleted the hf-minor branch November 13, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

HttpFoundation Status: Needs Review

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

2 participants

@nicolas-grekas @carsonbot