Page MenuHomePhabricator

MediaWiki-extensions-LinterComponent
ActivePublic

Members (4)

Watchers (7)

Details

Description

The Linter extension tracks lint errors from an external service. Currently the main use case is to track the errors identified by Parsoid and expose them to editors.

https://www.mediawiki.org/wiki/Extension:Linter

Recent Activity

Yesterday

Maintenance_bot edited projects for T368722: Empty headings are missing edit-source button in parsoid read views, added: User-notice-archive; removed User-notice.
Fri, May 23, 2:30 PM · User-notice-archive, MW-1.44-notes (1.44.0-wmf.25; 2025-04-15), MediaWiki-extensions-Linter, Parsoid-Read-Views, Content-Transform-Team (Work In Progress), OKR-Work, Parsoid

Thu, May 22

cscott merged task T286355: Templates expanding to mapframe extensions with large bodies exceed wikitext limits into T392262: Make limit reports match between legacy and Parsoid.
Thu, May 22, 6:09 PM · Parsoid, MediaWiki-extensions-Linter
cscott merged task T333754: Missing Lint error list updates for one page into T392261: Investigate crashers (out of memory, timeouts).
Thu, May 22, 6:07 PM · Parsoid, MediaWiki-extensions-Linter

Wed, May 21

ABreault-WMF added a comment to T200517: Emit lint error or category when a page uses duplicate HTML IDs.

@MarcoSwart That fix was deployed. I purged a few pages that included the template and they no longer have duplicate id errors.

Wed, May 21, 10:28 PM · MW-1.43-notes (1.43.0-wmf.28; 2024-10-22), Essential-Work, Content-Transform-Team-WIP, Parsoid, MediaWiki-extensions-Linter
ABreault-WMF closed T393982: Duplicate IDs regression for mw:FallbackId spans as Resolved.
Wed, May 21, 10:20 PM · Content-Transform-Team (Work In Progress), Essential-Work, MediaWiki-extensions-Linter, Parsoid
ABreault-WMF added a comment to T393230: False linter positives if headers contain non-ASCII characters.

@RolandUnger T393982 is deployed and I purged a few pages to confirm it fixed the issue

Wed, May 21, 10:20 PM · Parsoid-Rendering, MediaWiki-extensions-Linter
ABreault-WMF moved T393982: Duplicate IDs regression for mw:FallbackId spans from To Deploy to To Verify on the Content-Transform-Team (Work In Progress) board.
Wed, May 21, 10:14 PM · Content-Transform-Team (Work In Progress), Essential-Work, MediaWiki-extensions-Linter, Parsoid

Mon, May 19

Maintenance_bot removed a project from T393982: Duplicate IDs regression for mw:FallbackId spans: Patch-For-Review.
Mon, May 19, 8:31 PM · Content-Transform-Team (Work In Progress), Essential-Work, MediaWiki-extensions-Linter, Parsoid
gerritbot added a comment to T393982: Duplicate IDs regression for mw:FallbackId spans.

Change #1147810 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.22.0-a3

https://gerrit.wikimedia.org/r/1147810

Mon, May 19, 8:29 PM · Content-Transform-Team (Work In Progress), Essential-Work, MediaWiki-extensions-Linter, Parsoid
gerritbot added a project to T393982: Duplicate IDs regression for mw:FallbackId spans: Patch-For-Review.
Mon, May 19, 4:36 PM · Content-Transform-Team (Work In Progress), Essential-Work, MediaWiki-extensions-Linter, Parsoid
gerritbot added a comment to T393982: Duplicate IDs regression for mw:FallbackId spans.

Change #1147810 had a related patch set uploaded (by Jgiannelos; author: Jgiannelos):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.22.0-a3

https://gerrit.wikimedia.org/r/1147810

Mon, May 19, 4:36 PM · Content-Transform-Team (Work In Progress), Essential-Work, MediaWiki-extensions-Linter, Parsoid

Thu, May 15

ABreault-WMF added a comment to T393230: False linter positives if headers contain non-ASCII characters.

@RolandUnger Thanks for reporting. This should be fixed by T393982 rolling out next week

Thu, May 15, 4:07 PM · Parsoid-Rendering, MediaWiki-extensions-Linter
ABreault-WMF merged T393230: False linter positives if headers contain non-ASCII characters into T393982: Duplicate IDs regression for mw:FallbackId spans.
Thu, May 15, 4:06 PM · Content-Transform-Team (Work In Progress), Essential-Work, MediaWiki-extensions-Linter, Parsoid
ABreault-WMF merged task T393230: False linter positives if headers contain non-ASCII characters into T393982: Duplicate IDs regression for mw:FallbackId spans.
Thu, May 15, 4:06 PM · Parsoid-Rendering, MediaWiki-extensions-Linter

Wed, May 14

RolandUnger added a project to T393230: False linter positives if headers contain non-ASCII characters: Parsoid-Rendering.
Wed, May 14, 4:41 AM · Parsoid-Rendering, MediaWiki-extensions-Linter

Tue, May 13

ABreault-WMF triaged T393982: Duplicate IDs regression for mw:FallbackId spans as Medium priority.
Tue, May 13, 2:13 PM · Content-Transform-Team (Work In Progress), Essential-Work, MediaWiki-extensions-Linter, Parsoid
ABreault-WMF moved T393982: Duplicate IDs regression for mw:FallbackId spans from Needs Triage to Bugs & Crashers on the Parsoid board.

This is probably what was reported in https://phabricator.wikimedia.org/T200517#10785684, correct?

Tue, May 13, 2:13 PM · Content-Transform-Team (Work In Progress), Essential-Work, MediaWiki-extensions-Linter, Parsoid
ABreault-WMF added a comment to T200517: Emit lint error or category when a page uses duplicate HTML IDs.

On nl.wiktionary, this template generates the Lint error for duplicate IDs, even though it doesn't assign HTML IDs. Could this result from using the same subheadings within the template? If so, why should this be an error? HTML does not preclude using the same header several times.

Tue, May 13, 2:11 PM · MW-1.43-notes (1.43.0-wmf.28; 2024-10-22), Essential-Work, Content-Transform-Team-WIP, Parsoid, MediaWiki-extensions-Linter
Maintenance_bot removed a project from T393982: Duplicate IDs regression for mw:FallbackId spans: Patch-For-Review.
Tue, May 13, 9:30 AM · Content-Transform-Team (Work In Progress), Essential-Work, MediaWiki-extensions-Linter, Parsoid
gerritbot added a comment to T393982: Duplicate IDs regression for mw:FallbackId spans.

Change #1144689 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Don't emit duplicate id lint errors from mw:FallbackId spans

https://gerrit.wikimedia.org/r/1144689

Tue, May 13, 8:40 AM · Content-Transform-Team (Work In Progress), Essential-Work, MediaWiki-extensions-Linter, Parsoid
ihurbain added a comment to T393982: Duplicate IDs regression for mw:FallbackId spans.

This is probably what was reported in https://phabricator.wikimedia.org/T200517#10785684, correct?

Tue, May 13, 8:14 AM · Content-Transform-Team (Work In Progress), Essential-Work, MediaWiki-extensions-Linter, Parsoid
gerritbot added a project to T393982: Duplicate IDs regression for mw:FallbackId spans: Patch-For-Review.
Tue, May 13, 12:27 AM · Content-Transform-Team (Work In Progress), Essential-Work, MediaWiki-extensions-Linter, Parsoid
gerritbot added a comment to T393982: Duplicate IDs regression for mw:FallbackId spans.

Change #1144689 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Don't emit duplicate id lint errors from mw:FallbackId spans

https://gerrit.wikimedia.org/r/1144689

Tue, May 13, 12:27 AM · Content-Transform-Team (Work In Progress), Essential-Work, MediaWiki-extensions-Linter, Parsoid
ABreault-WMF created T393982: Duplicate IDs regression for mw:FallbackId spans.
Tue, May 13, 12:12 AM · Content-Transform-Team (Work In Progress), Essential-Work, MediaWiki-extensions-Linter, Parsoid

Mon, May 12

ABreault-WMF closed T393730: Empty heading with language link on talk page as Invalid.

From https://en.wikipedia.org/wiki/Wikipedia_talk:Linter#c-Zinnober9-20250509155800-ABreault_(WMF)-20250508190400

Mon, May 12, 8:26 PM · MediaWiki-extensions-Linter, Parsoid

Thu, May 8

ABreault-WMF created T393730: Empty heading with language link on talk page.
Thu, May 8, 6:49 PM · MediaWiki-extensions-Linter, Parsoid
cscott merged T330036: Linter updates in a Parsoid-in-ParserCache world into T393717: Put lints in ParserOutput/RefreshLinksJob.
Thu, May 8, 2:33 PM · MediaWiki-extensions-Linter
cscott merged task T330036: Linter updates in a Parsoid-in-ParserCache world into T393717: Put lints in ParserOutput/RefreshLinksJob.
Thu, May 8, 2:33 PM · MediaWiki-Platform-Team (Radar), RESTBase Sunsetting, MediaWiki-extensions-Linter
cscott added a comment to T330036: Linter updates in a Parsoid-in-ParserCache world.

At the last engineering offsite, we decided that putting lints into ParserOutput was the future direction here. I'm going to close this as a dupe of T393717: Put lints in ParserOutput/RefreshLinksJob to reflect this consensus.

Thu, May 8, 2:32 PM · MediaWiki-Platform-Team (Radar), RESTBase Sunsetting, MediaWiki-extensions-Linter
cscott merged T370624: Reduce concurrency of RecordLintJobs or shard it per section into T393717: Put lints in ParserOutput/RefreshLinksJob.
Thu, May 8, 2:32 PM · MediaWiki-extensions-Linter
cscott merged task T370624: Reduce concurrency of RecordLintJobs or shard it per section into T393717: Put lints in ParserOutput/RefreshLinksJob.
Thu, May 8, 2:32 PM · Content-Transform-Team, RESTBase Sunsetting, MediaWiki-extensions-Linter
cscott added a comment to T370624: Reduce concurrency of RecordLintJobs or shard it per section.

We decided at the last engineering offsite that Lints are going to be put into ParserOutput, and that we'll move the DB maintenance to RefreshLinksJob, although not until RLJ is powered by Parsoid (T393716). I'm going to close this as a duplicate of T393717: Put lints in ParserOutput/RefreshLinksJob to reflect this consensus.

Thu, May 8, 2:31 PM · Content-Transform-Team, RESTBase Sunsetting, MediaWiki-extensions-Linter
cscott added a subtask for T393717: Put lints in ParserOutput/RefreshLinksJob: T393716: RefreshLinksJob should use Parsoid-generated metadata.
Thu, May 8, 2:27 PM · MediaWiki-extensions-Linter
cscott created T393717: Put lints in ParserOutput/RefreshLinksJob.
Thu, May 8, 2:26 PM · MediaWiki-extensions-Linter
MSantos assigned T370624: Reduce concurrency of RecordLintJobs or shard it per section to cscott.
Thu, May 8, 2:13 PM · Content-Transform-Team, RESTBase Sunsetting, MediaWiki-extensions-Linter
Jonesey95 added a comment to T393538: Linter reports "night-mode-unaware-background-color" error even though color is defined.

Thanks for these answers, even though they are dissatisfying. I would hope that the parser could check the actual output for compliance with having both a color: and a background-color: specified, since that is the underlying concern.

Thu, May 8, 1:11 AM · MediaWiki-extensions-Linter

Wed, May 7

Jdlrobson-WMF added a comment to T393538: Linter reports "night-mode-unaware-background-color" error even though color is defined.

Sorry yes. Amended my comment above to be less confusing.

Wed, May 7, 9:46 PM · MediaWiki-extensions-Linter
ABreault-WMF added a comment to T393538: Linter reports "night-mode-unaware-background-color" error even though color is defined.

Here color: inherit; should be added to the inline style to fix it

Wed, May 7, 9:44 PM · MediaWiki-extensions-Linter
Jdlrobson-WMF added a comment to T393538: Linter reports "night-mode-unaware-background-color" error even though color is defined.

The lint is working as designed. The expectation is that you do not mix inline styles with TemplateStyles. Here color: inherit; should be added to the inline style to fix it, or the style should be completely moved into a rule for legend-color as the default.

Wed, May 7, 8:49 PM · MediaWiki-extensions-Linter
ABreault-WMF updated subscribers of T393538: Linter reports "night-mode-unaware-background-color" error even though color is defined.
Wed, May 7, 8:11 PM · MediaWiki-extensions-Linter
ABreault-WMF updated subscribers of T393538: Linter reports "night-mode-unaware-background-color" error even though color is defined.
Wed, May 7, 8:11 PM · MediaWiki-extensions-Linter
ABreault-WMF updated subscribers of T393538: Linter reports "night-mode-unaware-background-color" error even though color is defined.

The check is alas on the source string and unfortunately not on what gets resolved for the node,

Wed, May 7, 8:09 PM · MediaWiki-extensions-Linter
Jonesey95 updated the task description for T393538: Linter reports "night-mode-unaware-background-color" error even though color is defined.
Wed, May 7, 5:36 AM · MediaWiki-extensions-Linter
Jonesey95 created T393538: Linter reports "night-mode-unaware-background-color" error even though color is defined.
Wed, May 7, 5:35 AM · MediaWiki-extensions-Linter

Tue, May 6

Ladsgroup added a comment to T370624: Reduce concurrency of RecordLintJobs or shard it per section.

@Ladsgroup what's the status of this task? Is there something that still needs to be done?

Tue, May 6, 9:51 AM · Content-Transform-Team, RESTBase Sunsetting, MediaWiki-extensions-Linter
ABreault-WMF closed T368722: Empty headings are missing edit-source button in parsoid read views as Resolved.

Can you say a bit more about how it's being used and why it's necessary?

Tue, May 6, 12:27 AM · User-notice-archive, MW-1.44-notes (1.44.0-wmf.25; 2025-04-15), MediaWiki-extensions-Linter, Parsoid-Read-Views, Content-Transform-Team (Work In Progress), OKR-Work, Parsoid
ABreault-WMF moved T368722: Empty headings are missing edit-source button in parsoid read views from To Deploy to To Verify on the Content-Transform-Team (Work In Progress) board.
Tue, May 6, 12:21 AM · User-notice-archive, MW-1.44-notes (1.44.0-wmf.25; 2025-04-15), MediaWiki-extensions-Linter, Parsoid-Read-Views, Content-Transform-Team (Work In Progress), OKR-Work, Parsoid

Sat, May 3

Pppery removed a project from T393230: False linter positives if headers contain non-ASCII characters: MediaWiki-extensions-UnicodeConverter.
Sat, May 3, 12:40 PM · Parsoid-Rendering, MediaWiki-extensions-Linter
RolandUnger created T393230: False linter positives if headers contain non-ASCII characters.
Sat, May 3, 5:53 AM · Parsoid-Rendering, MediaWiki-extensions-Linter

Fri, May 2

MarcoSwart added a comment to T200517: Emit lint error or category when a page uses duplicate HTML IDs.

On nl.wiktionary, this template generates the Lint error for duplicate IDs, even though it doesn't assign HTML IDs. Could this result from using the same subheadings within the template? If so, why should this be an error? HTML does not preclude using the same header several times.

Fri, May 2, 11:01 AM · MW-1.43-notes (1.43.0-wmf.28; 2024-10-22), Essential-Work, Content-Transform-Team-WIP, Parsoid, MediaWiki-extensions-Linter