Change #1149686 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] fix(ArticleListItem): use correct log method

https://gerrit.wikimedia.org/r/1149686

Thanks both for reporting, tentative fix 1149686: fix(ArticleListItem): use correct log method

Change #1149686 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] fix(ArticleListItem): use correct log method

https://gerrit.wikimedia.org/r/1149686

It seems that Codex's Popover has a min-width set to size-1600 which ends up being 16rem and overflowing in such a small screen (source). Even removing it seems to result on a 256px popover which overflows in small screens. It seems to come from the minClipWidth set in JS. Changing it to a lower value, eg: 208 seems to work but I don't know if it has undesired side effects. See tentative fix 1149679 cc @lwatson and @AnneT

Change #1149679 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[design/codex@main] fix(Popover): remove min-width and lower down minClipWidth

https://gerrit.wikimedia.org/r/1149679

Change #1149349 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] SpecialHomepageLogger: Populate email state even with StartModule disabled

https://gerrit.wikimedia.org/r/1149349

Change #1149611 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/GrowthExperiments@master] Remove GEHomepageNewAccountEnablePercentage config option

https://gerrit.wikimedia.org/r/1149611

Moving to Test in Production since the last patch will be deployed for wmf.3.

In T391102#10842925, @Michael wrote:

refactor(ArticleList): use CdxPopover instead of CPopover seems to be causing event logging validation errors: '.event' should have required property 'action', '.event.mode' should be equal to one of the allowed values from https://logstash.wikimedia.org/app/discover#/doc/logstash-*/logstash-default-1-7.0.0-1-2025.05.21?id=0gTf8ZYBwY1fV78OiJbd

In T394435#10848807, @Michael wrote:

Though this is ultimately @KStoller-WMF's call to make: Are we likely to again run an experiment where we do not enable the help-panel by default for new users, or could we remove the scaffolding for that as well?

@Cyndymediawiksim No and Yes. On the one hand, I'm not actully seeing the dependency issue. With this task as written GEHomepageNewAccountEnablePercentage would just always be true. So we would change GEHelpPanelNewAccountEnableWithHomepage to:

@Michael , while working on removing GEHomepageNewAccountEnablePercentage as specified in the AC, I've identified a dependency issue that needs clarification before proceeding.
The GEHelpPanelNewAccountEnableWithHomepage configuration creates a logical dependency on GEHomepageNewAccountEnablePercentage that we're removing:

"GEHelpPanelNewAccountEnableWithHomepage": {
			"description": "By default, the help panel is enabled for new accounts in lockstep with the homepage, controlled by GEHomepageNewAccountEnablePercentage. To disable this behavior and use GEHelpPanelNewAccountEnablePercentage instead, set this to false.",
			"value": true
		},

Change #1149349 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] SpecialHomepageLogger: Populate email state even with StartModule disabled

https://gerrit.wikimedia.org/r/1149349

Nevermind the above change, this was me attaching the wrong phab id for the backport. Already fixed.

Before I do delete it, here's the error

It looks like one of the runs did fail - the logs can be seen in kubectl logs growthexperiments-refreshlinkrecommendations-s3-29131167-sfgdv mediawiki-main-app:

... lots of output ...
xmfwiki     fetching 500 tasks...
RuntimeException from line 328 of /srv/mediawiki/php-1.45.0-wmf.1/extensions/GrowthExperiments/maintenance/refreshLinkRecommendations.php: Search error: Search is currently too busy. Please try again later.
#0 /srv/mediawiki/php-1.45.0-wmf.1/extensions/GrowthExperiments/maintenance/refreshLinkRecommendations.php(435): GrowthExperiments\Maintenance\RefreshLinkRecommendations->findArticlesInTopic('engineering')
#1 /srv/mediawiki/php-1.45.0-wmf.1/extensions/GrowthExperiments/maintenance/refreshLinkRecommendations.php(148): GrowthExperiments\Maintenance\RefreshLinkRecommendations->refreshViaOresTopics(false)
#2 /srv/mediawiki/php-1.45.0-wmf.1/maintenance/includes/MaintenanceRunner.php(694): GrowthExperiments\Maintenance\RefreshLinkRecommendations->execute()
#3 /srv/mediawiki/php-1.45.0-wmf.1/maintenance/run.php(51): MediaWiki\Maintenance\MaintenanceRunner->run()
#4 /srv/mediawiki/multiversion/MWScript.php(221): require_once('/srv/mediawiki/...')
#5 {main}

If you look at kubectl describe job for these two:

cgoubert@deploy1003:/srv/deployment-charts/helmfile.d/services/mw-cron$ kubectl describe job growthexperiments-refreshlinkrecommendations-s3-29131167 | grep Status
Pods Statuses:    0 Active / 0 Succeeded / 1 Failed
cgoubert@deploy1003:/srv/deployment-charts/helmfile.d/services/mw-cron$ kubectl describe job growthexperiments-refreshlinkrecommendations-s3-29131587 | grep Status
Pods Statuses:    1 Active / 0 Succeeded / 0 Failed

Change #1149345 had a related patch set uploaded (by Michael Große; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@wmf/1.45.0-wmf.2] stats(SuggestedEdits): avoid tracking negative tti durations

https://gerrit.wikimedia.org/r/1149345

Hey @hnowlan or @Clement_Goubert, we are getting an alert about the growthexperiments-refreshlinkrecommendations-s3 having failed. Though from the logs, we can't tell the cause.

Change #1148914 merged by Hnowlan:

[operations/puppet@production] mw::maintenance: migrate all remaining growthexperiments jobs

https://gerrit.wikimedia.org/r/1148914

Change #1147116 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] tests: Make PHPUnit data provider static

https://gerrit.wikimedia.org/r/1147116

Change #1148914 had a related patch set uploaded (by Hnowlan; author: Hnowlan):

[operations/puppet@production] mw::maintenance: migrate all remaining growthexperiments jobs

https://gerrit.wikimedia.org/r/1148914