Details
Today
Yes, it sounds like we do want to do that. (Discussion was on WMF Slack.)
Yesterday
Mon, May 19
Thu, May 15
Everything seems in order now!
Wed, May 14
I never did add the snapshot tests. They were tedious to review and made me question how important they are. Perhaps we should do it only for sub-components, or something.
Still present on e.g. https://www.wikifunctions.org/view/en/Z24659?success=true
Do we still want to change this so that the bookmark icon is shown in the tab header only when there are no favorites, and then not shown if there are any?
Mon, May 12
Fri, May 9
QA is completed, I have verified the new code has been implemented and is functioning as expected Per the Acceptance Criteria (Testing was performed with a single wiki and also multiple wikis via wikifarm/Desktop View/Mobile View/various skins/Temporary Accounts that were not expired/expired Temporary Accounts). Great job @Tchanders, and thank you.
Thu, May 8
Change #1143175 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Specify icon to use in IP auto-reveal tool link in Minerva
Wed, May 7
@Djackson-ctr Once the above patch is merged, the IP auto-reveal link should be visible in the tool links menu on mobile:
Change #1143175 had a related patch set uploaded (by Tchanders; author: Tchanders):
[mediawiki/extensions/CheckUser@master] Specify icon to use in IP auto-reveal tool link in Minerva
Hello @KColeman-WMF:
I have a question for you...
During my testing of this ticket I have noticed that the IP auto-reveal link was not showing in Mobile view nor on the MinervaNeue skin...
The design mockups in the ticket description are showing as a Desktop view...
Is this feature only for Desktop view?
Mon, May 5
Change #1141950 had a related patch set uploaded (by Jdlrobson; author: Simon04):
[mediawiki/skins/MinervaNeue@master] Use browser native URL instead of mw.Uri
Any additional bugs found and remaining issues are being dealt with in T388385 (or tickets created and linked from there) so I am sending this to product sign off
Change #1141526 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] UserInfo: Add Thanks given/received data points
Sun, May 4
Change #1141526 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):
[mediawiki/extensions/CheckUser@master] UserInfo: Add Thanks given/received data points
Change #1141453 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] UserInfoCard: Return early if user impact data doesn't exist
Change #1141453 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):
[mediawiki/extensions/CheckUser@master] UserInfoCard: Return early if user impact data doesn't exist
Sat, May 3
Fri, May 2
Unsure if related, but in https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php81/12434/console (for r1140485 in ext/Cite) I saw the following (using browser timezone):
@aaron This is complete now, right?
Thu, May 1
Change #1135512 merged by jenkins-bot:
[mediawiki/core@master] DomainEvents: Remove deprecated DomainEvent-related alias classes and methods