Page MenuHomePhabricator

Od1n
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
May 8 2016, 3:49 PM (477 w, 6 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Od1n [ Global Accounts ]

Recent Activity

Wed, Jun 25

Od1n added a comment to T397496: Remove obsolete #toolbar fixed height CSS from some skins.

The removal of height: 22px causes the toolbar to occupy slightly more vertical space (exactly 22.292px in my current test). Previously, it was precisely 22px but slightly overlapped the textarea.

Wed, Jun 25, 5:08 AM · MW-1.45-notes (1.45.0-wmf.7; 2025-06-24), CSS, Timeless, Splash, MediaWiki-skins-Pivot, MediaWiki-skins-Foreground, Technical-Debt

Mon, Jun 23

Od1n added a comment to T397496: Remove obsolete #toolbar fixed height CSS from some skins.

Refs related: Gerrit 1161826 — removal of the mw-toolbar-editbutton class (which appears to have been done a bit too hastily).

Mon, Jun 23, 3:36 AM · MW-1.45-notes (1.45.0-wmf.7; 2025-06-24), CSS, Timeless, Splash, MediaWiki-skins-Pivot, MediaWiki-skins-Foreground, Technical-Debt

Fri, Jun 20

Od1n removed a project from T30856: Remove classic edit toolbar from core: Patch-For-Review.
Fri, Jun 20, 5:35 PM · MW-1.45-notes (1.45.0-wmf.7; 2025-06-24), User-notice-archive, MW-1.32-notes, MW-1.29-release-notes, Technical-Debt, JavaScript, MediaWiki-Page-editing
Od1n added a comment to T30856: Remove classic edit toolbar from core.

I have since identified other similar changes that need to be made, and I have opened a new task, T397496, to track them.

Fri, Jun 20, 4:41 AM · MW-1.45-notes (1.45.0-wmf.7; 2025-06-24), User-notice-archive, MW-1.32-notes, MW-1.29-release-notes, Technical-Debt, JavaScript, MediaWiki-Page-editing
Od1n added a comment to T397496: Remove obsolete #toolbar fixed height CSS from some skins.

I have submitted patches for the first four skins. Regarding the fifth one, Skin:Chameleon, it is only hosted on GitHub…

Fri, Jun 20, 4:30 AM · MW-1.45-notes (1.45.0-wmf.7; 2025-06-24), CSS, Timeless, Splash, MediaWiki-skins-Pivot, MediaWiki-skins-Foreground, Technical-Debt
Od1n created T397496: Remove obsolete #toolbar fixed height CSS from some skins.
Fri, Jun 20, 3:52 AM · MW-1.45-notes (1.45.0-wmf.7; 2025-06-24), CSS, Timeless, Splash, MediaWiki-skins-Pivot, MediaWiki-skins-Foreground, Technical-Debt

Thu, Jun 19

Od1n added a comment to T30856: Remove classic edit toolbar from core.

Now that https://gerrit.wikimedia.org/r/c/mediawiki/core/+/317079 was merged in 2018 (and in particular, see the changes at the bottom of this page), we should undo https://gerrit.wikimedia.org/r/c/mediawiki/core/+/373403 (which was merged in 2017): its CSS is now useless, as we are no longer inserting empty #toolbar elements.

Thu, Jun 19, 4:59 PM · MW-1.45-notes (1.45.0-wmf.7; 2025-06-24), User-notice-archive, MW-1.32-notes, MW-1.29-release-notes, Technical-Debt, JavaScript, MediaWiki-Page-editing

Fri, Jun 13

Od1n added a comment to T373711: Add support for Scribunto, JavaScript, CSS, JSON and Vue to CodeMirror 6.

Since it hasn't been brought up yet on this ticket, I wanted to mention that the AbuseFilter's rules editor also currently uses Ace Editor. What's particularly noteworthy here is that AbuseFilter rules are their own distinct language, not one of the standard content models being discussed for CodeMirror 6 support.

Fri, Jun 13, 4:03 PM · MW-1.45-notes (1.45.0-wmf.9; 2025-07-08), MW-1.44-notes (1.44.0-wmf.28; 2025-05-06), MediaWiki-extensions-CodeMirror

Tue, Jun 10

Od1n triaged T335133: Add keywords and functions for case-insensitive plaintext search as Low priority.
Tue, Jun 10, 5:16 PM · AbuseFilter
Od1n added a comment to T200942: file_sha1 must be given in lowercase.

I think that no assumption should be made about the case of file_sha1, as it is subject to change without notice. Also, in the context of a hexadecimal string, "a" and "A" have exactly the same significance.

Tue, Jun 10, 5:16 PM · AbuseFilter
Od1n added a comment to T391811: Rename 'all_links' to 'new_links'.

I explored alternative approaches using AI but couldn't find a better solution.

Tue, Jun 10, 4:50 PM · User-notice, MW-1.45-notes (1.45.0-wmf.7; 2025-06-24), AbuseFilter
Od1n added a comment to T391811: Rename 'all_links' to 'new_links'.

However, new_links introduces an ambiguity: it could suggest that the variable contains "new links" only, meaning "added links," whereas it actually refers to "all links of the new revision". The new_html and new_text variables are less affected by this potential misunderstanding.

Tue, Jun 10, 4:32 PM · User-notice, MW-1.45-notes (1.45.0-wmf.7; 2025-06-24), AbuseFilter

Sat, Jun 7

Od1n added a comment to T381537: Raise Grade A JavaScript requirement from ES2016 (ES7) to ES2017 (ES8).

Thank you for the explanation. The USERJSPARSE_CACHE_VERSION is simply located in /includes/ResourceLoader/Module.php.

Sat, Jun 7, 5:07 AM · User-notice-archive, MW-1.45-notes (1.45.0-wmf.6; 2025-06-17), Patch-For-Review, MediaWiki-Platform-Team, MediaWiki-ResourceLoader, JavaScript

Fri, Jun 6

Od1n added a comment to T381537: Raise Grade A JavaScript requirement from ES2016 (ES7) to ES2017 (ES8).

Interestingly, a user resolved the issue by modifying the relevant script to force a server-side refresh. However, it seems problematic that such an intervention was necessary. Is there a way to enhance the process to avoid this workaround?

Fri, Jun 6, 10:09 AM · User-notice-archive, MW-1.45-notes (1.45.0-wmf.6; 2025-06-17), Patch-For-Review, MediaWiki-Platform-Team, MediaWiki-ResourceLoader, JavaScript
Od1n added a comment to T381537: Raise Grade A JavaScript requirement from ES2016 (ES7) to ES2017 (ES8).

We have an issue on frwiki. Although we have been updated to 1.45.0-wmf.4 as expected, we are encountering this error:

Fri, Jun 6, 8:39 AM · User-notice-archive, MW-1.45-notes (1.45.0-wmf.6; 2025-06-17), Patch-For-Review, MediaWiki-Platform-Team, MediaWiki-ResourceLoader, JavaScript

Jun 5 2025

Od1n added a comment to T228380: Tech debt: sunsetting of Graphite.

I was using these graphs to monitor AbuseFilter performance—specifically, average execution time over time and conditions used (there is a hard limit of 2,000—previously 1,000—that is subject to being hit). Is there a replacement for this dashboard?

Jun 5 2025, 3:19 AM · SRE Observability (FY2025/2026-Q1), MW-1.45-notes (1.45.0-wmf.1; 2025-05-13), Patch-For-Review, Technical-Debt, Observability-Metrics

Jun 2 2025

Od1n added a comment to T381537: Raise Grade A JavaScript requirement from ES2016 (ES7) to ES2017 (ES8).

Refs the Tech News page: Tech/News/2025/23. (I'm not sure why this link hasn't been added to the task description, so I didn't include it myself.)

Jun 2 2025, 8:57 AM · User-notice-archive, MW-1.45-notes (1.45.0-wmf.6; 2025-06-17), Patch-For-Review, MediaWiki-Platform-Team, MediaWiki-ResourceLoader, JavaScript

May 27 2025

Od1n added a comment to T381537: Raise Grade A JavaScript requirement from ES2016 (ES7) to ES2017 (ES8).

I used AI to tweak the announcement—you might find some of its changes worth picking up:

May 27 2025, 8:05 PM · User-notice-archive, MW-1.45-notes (1.45.0-wmf.6; 2025-06-17), Patch-For-Review, MediaWiki-Platform-Team, MediaWiki-ResourceLoader, JavaScript

May 25 2025

Od1n closed T336127: No warning is shown when previewing a "sanitized-css" page containing unsupported CSS as Resolved.

Looks like this is fixed now—turns out the change in SyntaxHighlight’s hook did the trick. Thanks to everyone who helped look into this! Closing the ticket.

May 25 2025, 12:01 AM · Regression, MediaWiki-Page-editing, TemplateStyles, css-sanitizer

May 20 2025

Od1n added a comment to T369784: nsText property of Title objects should contain spaces instead of underscores.

Refs T58217, which had already identified discrepancies in prefixedText and nsText, fixed the former but not the latter.

May 20 2025, 11:16 PM · Patch-For-Review, Scribunto
Od1n added a comment to T380317: Add missing tests for nsText property of title objects, and set it to nil for interwiki links.

⚠️🤔 There is something I don't understand:

  • The current value of this property is '' (empty string): as obtained with mw.title.new( 'interwikiprefix:Module:TestFramework' ).interwiki
  • However, the relevant unit test expects the value 'interwikiprefix': TitleLibraryTests.lua#L296.
May 20 2025, 11:10 PM · Patch-For-Review, Scribunto

May 19 2025

Od1n added a comment to T20157: Implement a {{#trim}}, {{#ltrim}}, {{#rtrim}} in StringFunctions.
  • I find the syntax with start/end parameters ({{trim:...|0|1}}) to be both awkward and uncommon.
    • Nevertheless, as I mentioned earlier, partial trims cannot be implemented since branches are automatically trimmed.
  • The term "trim" encompasses two distinct use cases:
    • A) Trimming for template coding purposes: Here, we should only remove spaces, newlines, and occasional tab characters.
      • Indeed, I am fairly certain that some values contain leading or trailing non-breaking spaces that we do not want to trim.
      • Additionally, since this function will be used frequently, it must be highly efficient—Unicode handling would undermine that.
    • B) Trimming for editorial purposes (?): In this case, we could consider trimming all possible spaces.
  • To start, I believe we should implement only the first mode (A).
    • If necessary later on, we could introduce a "mode" parameter: {{trim:...|BASIC}} (default) and {{trim:...|EXHAUSTIVE}}.
    • However, I am not convinced that mode B is widely needed. For rare cases, it could potentially be handled in a custom userland Lua module.
May 19 2025, 6:24 PM · ParserFunctions

May 18 2025

Od1n added a comment to T387143: Minerva footer hides new items by default.

As a side effect of removing the troublesome hack, the bug in T387797 surfaced.

May 18 2025, 9:52 PM · MW-1.44-notes (1.44.0-wmf.19; 2025-03-04), patch-welcome, MinervaNeue
Od1n added a comment to T387797: Stray dot in footer when page previews enabled.

Just for fun:

May 18 2025, 9:47 PM · Web-Team, patch-welcome, Page-Previews
Od1n added a comment to T382937: Improve repositioning of "Terms of Use" in footer links.

Refs T387143, which solved the issue at hand.

May 18 2025, 9:34 PM · MW-1.44-notes (1.44.0-wmf.19; 2025-03-04), MediaWiki-Core-Skin-Architecture, MediaWiki-User-Interface, MobileFrontend
Od1n added a comment to T387797: Stray dot in footer when page previews enabled.

I've just reviewed the patch code, and it looks pretty much ready. Maybe we could reactivate the patch, as it seems almost ready to be merged?

May 18 2025, 8:39 PM · Web-Team, patch-welcome, Page-Previews
Od1n added a comment to T20157: Implement a {{#trim}}, {{#ltrim}}, {{#rtrim}} in StringFunctions.

About ltrim and rtrim proposals: parser function branches are automatically trimmed, thus it may be difficult—and inconsistent—to implement these functions, as it would involve introducing some way to not trim spaces. Therefore, I'm not sure this would be a good idea.

May 18 2025, 12:35 PM · ParserFunctions
Od1n added a comment to T20157: Implement a {{#trim}}, {{#ltrim}}, {{#rtrim}} in StringFunctions.

ltrim and rtrim may be interesting proposals as well; however, these names are centered around left-to-right languages. A more inclusive approach would be to name them trimstart and trimend.

May 18 2025, 12:01 PM · ParserFunctions
Od1n added a comment to T20157: Implement a {{#trim}}, {{#ltrim}}, {{#rtrim}} in StringFunctions.

2025 here. 👋 I have just created T394604, and afterwards I noticed this ticket in a workboard.

May 18 2025, 11:56 AM · ParserFunctions
Od1n added projects to T394604: Implementing a {{trim:}} parser function: MediaWiki-Parser-Templates, MediaWiki-Parser, Parsoid.
May 18 2025, 11:53 AM · Parsoid, MediaWiki-Parser, MediaWiki-Parser-Templates, ParserFunctions
Od1n created T394604: Implementing a {{trim:}} parser function.
May 18 2025, 11:50 AM · Parsoid, MediaWiki-Parser, MediaWiki-Parser-Templates, ParserFunctions

May 16 2025

Od1n added a comment to T387778: [breaking change] Font modes: Introduce font modes to Codex.

Again on Vector classic, I just noticed another similar issue: on history pages, the font size of the "Compare selected revisions" button is too large.

May 16 2025, 12:31 PM · Patch-For-Review, Design-System-Team (DST-Sprint-45 (2025-04-14 to 2025-04-25)), Codex 2.0, Codex

May 15 2025

Od1n added a comment to T387778: [breaking change] Font modes: Introduce font modes to Codex.

On Vector classic, it seems that this changeset unexpectedly increased the font size of warning messages.

May 15 2025, 4:47 PM · Patch-For-Review, Design-System-Team (DST-Sprint-45 (2025-04-14 to 2025-04-25)), Codex 2.0, Codex

May 13 2025

Od1n added a comment to T324991: Make Wikibase not rely on the ResourceLoader target system.

For quite some time now, a JavaScript error has been occurring on Commons. See T321532 for details.

May 13 2025, 3:35 AM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), User-ItamarWMDE, [Archived]Wikidata Dev Team, wmde-wikidata-tech, Wikidata, Wikidata-Campsite, User-Jdlrobson, Technical-Debt (RW-Tech-Debt)
Od1n added a comment to T321532: Console error - 'Error: View mediainfoview does not exist' on Commons File pages.

I can easily reproduce this error as well. Come on, it's been occurring since 2022!

May 13 2025, 3:24 AM · Wikidata-UX, JavaScript, [DEPRECATED] wdwb-tech, Wikidata, SDC General, Wikimedia-production-error, WikibaseMediaInfo, Structured-Data-Backlog

Apr 26 2025

Od1n added a comment to T347299: Create a button to expand all collapsible elements on a page.

The wishlist request is not only about the "Find in page" browser functionality, it also seeks an easy way to uncollapse everything:

Apr 26 2025, 4:24 PM · MW-1.42-notes (1.42.0-wmf.19; 2024-02-20), Moderator-Tools-Team (Kanban), Wikimedia Wishathon

Apr 25 2025

Od1n added a comment to T178146: Add support for a newer Lua version than Lua 5.1 to luasandbox.

I have reviewed the lists of new features (Lua 5.2, Lua 5.3, Lua 5.4), and apart from the hexadecimal and Unicode escapes I mentioned earlier, I don't see anything particularly compelling. That said, I believe these escapes alone would justify implementing a newer Lua version.

Apr 25 2025, 8:28 PM · LuaSandbox, Scribunto

Apr 16 2025

Od1n added a comment to T178146: Add support for a newer Lua version than Lua 5.1 to luasandbox.

Some interesting new features, related to multibyte strings:

  • Lua 5.2 would let us use hexadecimal byte codes in strings, whereas we currently have to rely on decimal byte codes, which are very uncommon. Example: we could replace the very unusual \194\160 with \xC2\xA0.
  • Lua 5.3 would even let us use Unicode code points in strings. Example: \u{A0}.
    • These code points are converted into their corresponding sequences of UTF-8 bytes (as outlined here). Keep in mind, they remain multibyte strings and come with all the associated caveats when using native string.* functions.
Apr 16 2025, 2:07 AM · LuaSandbox, Scribunto

Apr 12 2025

Od1n added a comment to T313163: AbuseFilter API "aflprop=details" should allow querying finer grained variables.

Thankfully, there is some activity—the patch was recently rebased (patchset 4 on April 2nd).

Apr 12 2025, 9:15 AM · Patch-For-Review, AbuseFilter

Apr 8 2025

Od1n added a comment to T349303: Implement initial CSS Custom properties for font-size in Minerva Neue.

Considering that there is a code that migrates the user preference,
and that all code related to "xlarge" have been removed everywhere else,
we should remove the remaining .mf-font-size-clientpref-xlarge in mobile.less, which seems to be the only leftover.

Apr 8 2025, 8:45 PM · Verified, MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 2), FY2023-24-WE 2.1 Typography and palette customizations

Mar 22 2025

Od1n added a comment to T357197: Allow ES2017 (ES8) syntax in gadgets.

@Xover Note that browser requirements for the optional JavaScript layer are very different from browser requirements to render web pages (HTML/CSS). https://www.mediawiki.org/wiki/Compatibility#Browsers

Mar 22 2025, 9:48 AM · MediaWiki-Platform-Team (Radar), MediaWiki-extensions-Gadgets

Mar 21 2025

Od1n added a comment to T378319: An OOUI infuse that is unused.

Reminder to self: I have some local optimizations to tidy up and submit — most notably, avoiding execution of the #mw-abusefilter-syntaxresult DOM query on every character input. See ext.abuseFilter.edit.js#494 and ext.abuseFilter.edit.js#522.

Mar 21 2025, 4:34 AM · MW-1.44-notes (1.44.0-wmf.2; 2024-11-05), OOUI, JavaScript, AbuseFilter

Mar 20 2025

Od1n added a comment to T380943: Contributions page should add Codex message box styles to page.

Ok, it has already been fixed: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/10f306582cca6c9f8da989a91368beae8001dc19%5E%21/resources/lib/ooui/oojs-ui-core-apex.css

Mar 20 2025, 2:54 AM · MW-1.44-notes (1.44.0-wmf.6; 2024-12-03), MediaWiki-Special-pages
Od1n added a comment to T380943: Contributions page should add Codex message box styles to page.

Currently, I observe the problem on frwiki and enwiki, but it appears to be correct on mediawiki.org. The latter applies an additional rule, box-sizing: border-box;.

Mar 20 2025, 2:49 AM · MW-1.44-notes (1.44.0-wmf.6; 2024-12-03), MediaWiki-Special-pages
Od1n added a comment to T380943: Contributions page should add Codex message box styles to page.

An effect of this is that the « ﹀ Search for contributions » box, when collapsed, has an increased height, and the legend line is no longer vertically centered.

Mar 20 2025, 2:41 AM · MW-1.44-notes (1.44.0-wmf.6; 2024-12-03), MediaWiki-Special-pages

Mar 9 2025

Od1n added a comment to T248416: [EPIC] Drop MediaWiki:Mobile.css and MediaWiki:Mobile.js in favor of TemplateStyles and MediaWiki:Minerva.css.

Please ignore the comment you are quoting. Even myself couldn't figure out a way to migrate the files if that path were followed.

Mar 9 2025, 10:15 PM · Readers Essential Work 2025, MobileFrontend, Epic, User-Jdlrobson
Od1n added a comment to T14974: The newline added to a template, magic word, variable, or parser function that returns line-start wikicode formatting (*#:; {|) causes unexpected parsing.

Indeed, this template call returns « :<space> », so as its return value starts with « : », it's yet another example of an issue arising from the current situation.

Mar 9 2025, 7:14 PM · Epic, MediaWiki-Parser

Mar 7 2025

Od1n added a comment to T388083: Headings selection needs to be updated in PageHTMLParser.

About the wgMFMobileFormatterHeadings config item, which comes from $config->get( 'MFMobileFormatterOptions' )['headings'] and is documented here, see T110436.

Mar 7 2025, 2:26 AM · Web-Team, JavaScript, MobileFrontend

Mar 6 2025

Od1n added a comment to T220751: [Bug] Extreme latency due to JavaScript parsing on DOM-heavy pages.

I opened a dedicated ticket for that issue: T388083.

Mar 6 2025, 12:26 AM · Performance-Team (Radar), Web-Team-Backlog-Archived, MW-1.34-notes (1.34.0-wmf.1; 2019-04-16)
Od1n added a comment to T13555: .mw-editsection links should not be part of the <h#> element.

Done, here: T388083. Feel free to edit it.

Mar 6 2025, 12:24 AM · User-notice-archive, Editing-team (Tracking), MW-1.43-notes (1.43.0-wmf.7; 2024-05-28), MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Web-Team-Backlog-Archived (Needs Prioritization (Tech)), Technical-Debt, Epic, Accessibility, MediaWiki-Parser
Od1n created T388083: Headings selection needs to be updated in PageHTMLParser.
Mar 6 2025, 12:23 AM · Web-Team, JavaScript, MobileFrontend

Mar 5 2025

Od1n added a comment to T248416: [EPIC] Drop MediaWiki:Mobile.css and MediaWiki:Mobile.js in favor of TemplateStyles and MediaWiki:Minerva.css.

tl;dr: 1) Ditch the terrible JS-loading of Mobile.css (for emphasis: keep this file). 2) Provide common files for desktop and mobile, we are awaiting for these files for way too long. 3) Relish the relief that is finally taking shape.

Mar 5 2025, 2:57 PM · Readers Essential Work 2025, MobileFrontend, Epic, User-Jdlrobson
Od1n added a comment to T248416: [EPIC] Drop MediaWiki:Mobile.css and MediaWiki:Mobile.js in favor of TemplateStyles and MediaWiki:Minerva.css.

Alternatively: Add right now Desktop.css/js files (so, they would be loaded the same as Common.css/js). Leave some time to editors. Then bite the bullet and load Common.css/js on all platforms.

Mar 5 2025, 2:45 PM · Readers Essential Work 2025, MobileFrontend, Epic, User-Jdlrobson
Od1n added a comment to T248416: [EPIC] Drop MediaWiki:Mobile.css and MediaWiki:Mobile.js in favor of TemplateStyles and MediaWiki:Minerva.css.

I know Common.css could be made loaded on mobile too. But I'm afraid it would be too much of a disturbance, considering how old the existing Common.css files are.

Mar 5 2025, 2:39 PM · Readers Essential Work 2025, MobileFrontend, Epic, User-Jdlrobson
Od1n added a comment to T248416: [EPIC] Drop MediaWiki:Mobile.css and MediaWiki:Mobile.js in favor of TemplateStyles and MediaWiki:Minerva.css.

Hence what I am suggesting as a next step: providing a true common CSS, for both desktop and mobile.

Mar 5 2025, 2:17 PM · Readers Essential Work 2025, MobileFrontend, Epic, User-Jdlrobson
Od1n added a comment to T220751: [Bug] Extreme latency due to JavaScript parsing on DOM-heavy pages.

It seems that this code needs to be updated, please have a look at T13555#10603383.

Mar 5 2025, 2:01 PM · Performance-Team (Radar), Web-Team-Backlog-Archived, MW-1.34-notes (1.34.0-wmf.1; 2019-04-16)
Od1n added a comment to T248416: [EPIC] Drop MediaWiki:Mobile.css and MediaWiki:Mobile.js in favor of TemplateStyles and MediaWiki:Minerva.css.

This current plan makes Minerva.css a de-facto Mobile.css. The problem with this approach is that it brings a strong mobile/Minerva coupling. It makes Minerva on desktop domain unmanageable (too much code conflicts), and much worse, it closes the door to implementing additional skins on mobile. I think this would be a bad move in the long term.

Mar 5 2025, 1:51 PM · Readers Essential Work 2025, MobileFrontend, Epic, User-Jdlrobson

Mar 4 2025

Od1n added a comment to T13555: .mw-editsection links should not be part of the <h#> element.

While doing some code browsing about an unrelated task, I noticed that, in MobileFrontend, some update may be needed in PageHTMLParser.js.

Mar 4 2025, 10:47 PM · User-notice-archive, Editing-team (Tracking), MW-1.43-notes (1.43.0-wmf.7; 2024-05-28), MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Web-Team-Backlog-Archived (Needs Prioritization (Tech)), Technical-Debt, Epic, Accessibility, MediaWiki-Parser

Mar 3 2025

Od1n added a comment to T319081: Add "contribs" link for IP edits in revision history.

We have gadgets, namely DeluxeHistory.js (which is quite popular) and AddContribNumberInNewPages.js, that on lists such as history pages:

Mar 3 2025, 2:05 PM · Trust and Safety Product Team, MediaWiki-Page-history
Od1n added a comment to T319081: Add "contribs" link for IP edits in revision history.

Note that in addition to lists such as history pages, recent changes, new pages, etc., such usernames are also displayed on diff views.

Mar 3 2025, 1:34 PM · Trust and Safety Product Team, MediaWiki-Page-history

Jan 26 2025

Od1n closed T374294: Support named capturing groups in get_matches() as Resolved.

Solved by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AbuseFilter/+/1071286

Jan 26 2025, 2:06 AM · MW-1.43-notes (1.43.0-wmf.22; 2024-09-10), AbuseFilter
Od1n closed T348717: Filter IDs and log entry IDs should not be num-formatted as Resolved.
Jan 26 2025, 1:46 AM · MW-1.43-notes (1.43.0-wmf.22; 2024-09-10), AbuseFilter
Od1n added a comment to T348717: Filter IDs and log entry IDs should not be num-formatted.

Solved by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AbuseFilter/+/965462

Jan 26 2025, 1:46 AM · MW-1.43-notes (1.43.0-wmf.22; 2024-09-10), AbuseFilter

Jan 24 2025

Od1n added a comment to T68637: Make it possible to distinguish Wikitext headings and HTML headings.

the tradeoff is that we can't distinguish == … == from <h2>…</h2> (with no attributes)

Jan 24 2025, 10:56 AM · MW-1.44-notes (1.44.0-wmf.27; 2025-04-29), MediaWiki-Parser

Jan 3 2025

Od1n added a comment to T382937: Improve repositioning of "Terms of Use" in footer links.

I don't think we should complicate the hook or any other PHP-related parts. I have already looked into this and suspected such a change would be complicated to implement. It wouldn't be justified for that single use case.

Jan 3 2025, 10:12 PM · MW-1.44-notes (1.44.0-wmf.19; 2025-03-04), MediaWiki-Core-Skin-Architecture, MediaWiki-User-Interface, MobileFrontend
Od1n updated the task description for T382937: Improve repositioning of "Terms of Use" in footer links.
Jan 3 2025, 4:18 PM · MW-1.44-notes (1.44.0-wmf.19; 2025-03-04), MediaWiki-Core-Skin-Architecture, MediaWiki-User-Interface, MobileFrontend
Od1n created T382937: Improve repositioning of "Terms of Use" in footer links.
Jan 3 2025, 5:39 AM · MW-1.44-notes (1.44.0-wmf.19; 2025-03-04), MediaWiki-Core-Skin-Architecture, MediaWiki-User-Interface, MobileFrontend
Od1n added a comment to T380317: Add missing tests for nsText property of title objects, and set it to nil for interwiki links.

Currently encountering an error during the unit tests, at this line: mw.title.lua#L91.
That is because of an attempt to concatenate the new value nil.

Jan 3 2025, 2:27 AM · Patch-For-Review, Scribunto

Jan 2 2025

Od1n closed T378281: Clean up legacy event creation code as Resolved.

There are many remaining instances of createEvent(), but almost all (if not all) are in embedded libraries.

Jan 2 2025, 7:26 AM · MW-1.44-notes (1.44.0-wmf.5; 2024-11-25), Technical-Debt, MediaWiki-General, JavaScript

Jan 1 2025

Od1n added a comment to T380317: Add missing tests for nsText property of title objects, and set it to nil for interwiki links.

Uploaded patchset 3. It now accomplishes two things:

  • Sets nsText to nil for interwiki links, as pointed out above.
  • Adds the missing unit tests, as originally intended.
Jan 1 2025, 8:51 PM · Patch-For-Review, Scribunto
Od1n renamed T380317: Add missing tests for nsText property of title objects, and set it to nil for interwiki links from Add missing tests for nsText property of title objects to Add missing tests for nsText property of title objects, and set it to nil for interwiki links.
Jan 1 2025, 8:35 PM · Patch-For-Review, Scribunto

Dec 21 2024

Od1n added a comment to T60137: Deprecate the SkinTemplateOutputPageBeforeExec hook.

In order to be able to prepend the item, I was considering to pass $data to the onSkinAddFooterLinks hook, instead of generating a $newItems that is then merged into $data.

Dec 21 2024, 6:27 AM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Web-Team-Backlog-Archived (Kanbanana-2019-20-Q4), MW-1.35-release, MediaWiki-Core-Skin-Architecture, User-Jdlrobson, Patch-For-Review, Vector 2022 (Desktop improvements), Technical-Debt (Deprecation process), MediaWiki-User-Interface

Dec 20 2024

Od1n added a comment to T60137: Deprecate the SkinTemplateOutputPageBeforeExec hook.

Mmmm, it wouldn't work this way, as $newItems is an empty array, that is populated by onSkinAddFooterLinks(), then back in getTemplateDataFooter() is merged to $data (using the foreach).

Dec 20 2024, 2:15 PM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Web-Team-Backlog-Archived (Kanbanana-2019-20-Q4), MW-1.35-release, MediaWiki-Core-Skin-Architecture, User-Jdlrobson, Patch-For-Review, Vector 2022 (Desktop improvements), Technical-Debt (Deprecation process), MediaWiki-User-Interface
Od1n closed T382514: Inconsistent outcome with "subst:" in Lua module expansion as Declined.
Dec 20 2024, 3:07 AM · Scribunto, MediaWiki-Parser-Templates, MediaWiki-Parser
Od1n added a comment to T382514: Inconsistent outcome with "subst:" in Lua module expansion.

I can accept your rationale, even though the resulting behavior is very counterintuitive.

Dec 20 2024, 3:05 AM · Scribunto, MediaWiki-Parser-Templates, MediaWiki-Parser

Dec 19 2024

Od1n added a comment to T382514: Inconsistent outcome with "subst:" in Lua module expansion.

It is similar to the usual issue with substed templates, where the inner templates (and parser functions, etc.) have to be substed as well.

Dec 19 2024, 6:44 PM · Scribunto, MediaWiki-Parser-Templates, MediaWiki-Parser
Od1n created T382514: Inconsistent outcome with "subst:" in Lua module expansion.
Dec 19 2024, 4:03 PM · Scribunto, MediaWiki-Parser-Templates, MediaWiki-Parser
Od1n added a comment to T60137: Deprecate the SkinTemplateOutputPageBeforeExec hook.

I noticed a strange #footer-places-terms-use { float: left; } style in the footer, which has been introduced in gerrit 596492.

Dec 19 2024, 3:23 AM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Web-Team-Backlog-Archived (Kanbanana-2019-20-Q4), MW-1.35-release, MediaWiki-Core-Skin-Architecture, User-Jdlrobson, Patch-For-Review, Vector 2022 (Desktop improvements), Technical-Debt (Deprecation process), MediaWiki-User-Interface

Dec 9 2024

Od1n added a comment to T14974: The newline added to a template, magic word, variable, or parser function that returns line-start wikicode formatting (*#:; {|) causes unexpected parsing.

Thanks for pointing this out. Good catch 👍

Dec 9 2024, 6:24 AM · Epic, MediaWiki-Parser

Dec 5 2024

Od1n added a comment to T148313: Put wrapped data in mw.loadData cache.

Jackmcbarn hasn't been active for years so won't respond.

Dec 5 2024, 2:13 PM · Performance Issue, Scribunto

Dec 1 2024

Od1n added a comment to T381224: Optimizing data encapsulation in mw.loadData() for enhanced efficiency.

Sorry, I had forgotten about that ticket T148313 (from 2016!).

Dec 1 2024, 9:08 PM · Scribunto
Od1n added a comment to T148313: Put wrapped data in mw.loadData cache.

(2024 here, coming from the duplicate T381224)

Dec 1 2024, 9:02 PM · Performance Issue, Scribunto
Od1n created T381224: Optimizing data encapsulation in mw.loadData() for enhanced efficiency.
Dec 1 2024, 4:26 PM · Scribunto

Nov 29 2024

Od1n added a comment to T381185: Unexpected link to « Spécial:Badtitle/Message » in system message of module documentation.

Thanks @Pppery for taking care of this.

Nov 29 2024, 8:16 PM · MW-1.44-notes (1.44.0-wmf.6; 2024-12-03), Scribunto
Od1n added a project to T381185: Unexpected link to « Spécial:Badtitle/Message » in system message of module documentation: Parsoid.
Nov 29 2024, 6:36 PM · MW-1.44-notes (1.44.0-wmf.6; 2024-12-03), Scribunto
Od1n created T381185: Unexpected link to « Spécial:Badtitle/Message » in system message of module documentation.
Nov 29 2024, 6:34 PM · MW-1.44-notes (1.44.0-wmf.6; 2024-12-03), Scribunto

Nov 26 2024

Od1n added a comment to T14974: The newline added to a template, magic word, variable, or parser function that returns line-start wikicode formatting (*#:; {|) causes unexpected parsing.

I just noticed something surprising, and it's making me ponder. 🤔

Nov 26 2024, 4:32 PM · Epic, MediaWiki-Parser
Od1n added a comment to T380317: Add missing tests for nsText property of title objects, and set it to nil for interwiki links.

I would suggest to be bold, and complete/correct gerrit 983410 by adding nsText to the list of properties that are set to nil. Considering how interwiki links are such a special case, I can't think of situations where this nsText change would break something.

Nov 26 2024, 4:04 AM · Patch-For-Review, Scribunto
Od1n added a comment to T380317: Add missing tests for nsText property of title objects, and set it to nil for interwiki links.

Tests are still failing, and it's quite interesting.

Nov 26 2024, 3:48 AM · Patch-For-Review, Scribunto

Nov 22 2024

Od1n closed T265203: Allow start/end values to be modified after the toolbar has been bootstrapped as Resolved.
Nov 22 2024, 9:16 AM · MW-1.41-notes (1.41.0-wmf.9; 2023-05-15), CharInsert

Nov 20 2024

Od1n closed T378319: An OOUI infuse that is unused as Resolved.

Nope, everything has been taken care of here.

Nov 20 2024, 3:03 AM · MW-1.44-notes (1.44.0-wmf.2; 2024-11-05), OOUI, JavaScript, AbuseFilter
Od1n added a comment to T369784: nsText property of Title objects should contain spaces instead of underscores.

The patch will have to be rebased after gerrit 1092899 is merged.

Nov 20 2024, 2:39 AM · Patch-For-Review, Scribunto
Od1n added a comment to T380317: Add missing tests for nsText property of title objects, and set it to nil for interwiki links.

Fixed tests: gerrit 1092899/1..2.

Nov 20 2024, 2:35 AM · Patch-For-Review, Scribunto

Nov 19 2024

Od1n created T380317: Add missing tests for nsText property of title objects, and set it to nil for interwiki links.
Nov 19 2024, 7:26 PM · Patch-For-Review, Scribunto

Nov 14 2024

Od1n added a comment to T369784: nsText property of Title objects should contain spaces instead of underscores.

On a related note, in TitleLibraryTests.lua there are tests for subjectNsText, and for talkNsText as well (T180911), but there are no tests for nsText.

Nov 14 2024, 2:43 AM · Patch-For-Review, Scribunto
Od1n added a comment to T180911: Add a property "talkNsText" to mw.title objects.

On a related note, in TitleLibraryTests.lua there are tests for subjectNsText, and now for talkNsText as well, but there are no tests for nsText.

Nov 14 2024, 2:43 AM · MW-1.42-notes (1.42.0-wmf.15; 2024-01-23), MediaWiki CodeJam Dec 2023, Scribunto

Nov 10 2024

Od1n added a comment to T378314: "Switch editor" and "Check syntax" buttons are misaligned.

The patch currently fails tests.

Nov 10 2024, 11:45 AM · Patch-For-Review, JavaScript, CSS, OOUI, AbuseFilter
Od1n added a comment to T378577: Fix Selenium tests, probably because of faulty switchEditor().

Note that although the patch passes the tests, gerrit 1083587 (T378314) has been rebased on it but still encounter errors.

Nov 10 2024, 11:39 AM · Patch-For-Review, AbuseFilter, Browser-Tests

Nov 9 2024

Od1n added a comment to T338942: Add a Lua function to get all sitelinks/ all badges.

Looking back at this ticket:

Nov 9 2024, 8:03 PM · Wikibase-Lua, MediaWiki-extensions-Wikibase-Client, Wikidata
Od1n added a comment to T305378: Add convenience function getBadges() to Lua .

Refs T179638, which is a more general application of the same principle (filtering properties to avoid loading the whole entity).

Nov 9 2024, 7:16 PM · MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), [Archived]Wikidata Dev Team (Sprint-∞), Wikidata-Campsite, Wikibase-Lua, MediaWiki-extensions-Wikibase-Client, Wikidata