Page MenuHomePhabricator
Create Task
Maniphest T148533

"(diff | hist)" are plain text and have no links for categorization entries in Recent Changes and Watchlist in non-grouping mode
Closed, ResolvedPublic5 Estimated Story Points
Actions

Assigned To
Kgraessle
Authored By
IKhitron
Oct 18 2016, 3:30 PM
Tags
Referenced Files
F58879895: Screenshot 2025-03-20 at 16.07.08.png
Mar 20 2025, 4:07 PM
F58879886: Screenshot 2025-03-20 at 16.06.23.png
Mar 20 2025, 4:07 PM
F58596169: Screenshot 2025-03-04 at 16.13.52.png
Mar 4 2025, 4:14 PM
F11797376: Screen Shot 2017-12-12 at 4.02.06 PM.png
Dec 13 2017, 12:37 AM
F11797378: Screen Shot 2017-12-12 at 4.02.27 PM.png
Dec 13 2017, 12:37 AM
F4646843: x.png
Oct 23 2016, 6:49 PM
F4646829: x.png
Oct 23 2016, 6:39 PM
F4644455: w.png
Oct 22 2016, 8:08 PM
View All 9 Files
Subscribers
Aklapper
eranroz
Etonkovidova
IKhitron
Kipod
Nardog
Samwalton9-WMF
Tokens
"Love" token, awarded by Krinkle.

Description

See More

Steps to reproduce

  1. Create (or choose) a category.
  2. Ensure 'Group results by page' is not selected in Special:RecentChanges.

Screenshot 2025-03-04 at 16.13.52.png (412×714 px, 41 KB)
  1. Add a page to the category from step 1.
  2. On Special:RecentChanges, select the 'Category changes' filter, and look at the entry for the page addition - diff and hist will not be linked.

If 'Group results by page' is selected, the diff and hist links are linked.

The non-grouped mode should treat these links the same as the grouped mode - linking to the edit that added/removed the category.

This is a succinct filtered view demonstrating the problem - https://en.wikipedia.org/wiki/Special:RecentChanges?hidepageedits=1&hidenewpages=1&hideWikibase=1&hidelog=1&hidenewuserlog=1&limit=50&days=7&urlversion=2&enhanced=0

Wishlist item: https://meta.wikimedia.org/wiki/Community_Wishlist/Wishes/Link_%22diff%22_and_%22hist%22_for_category_changes_on_Watchlist_RecentChanges

Resolved task for this issue in grouping mode: T270662: Diff and history links missing for grouped category changes on Watchlist/RecentChanges

Original description
Hi. Something strange. I allways use grouping mode for watchlist and recent changes in preferences. Today I removed it for a couple of minutes to check something, and saw that all categorigation entries do not have diff links. The words "( diff | history )" are just a plain text, without links. As I know it works well in grouping mode, so I'd like to understand: Was it done in purpose? Thank you.

Details

SubjectRepoBranchLines +/-
"(diff | hist)" are plain text and have no links for categorization entries in Recent Changes and Watchlist in non-grouping mode - Fix the hist plain text messagemediawiki/coremaster+16 -16
"(diff | hist)" are plain text and have no links for categorization entries in Recent Changes and Watchlist in non-grouping modemediawiki/coremaster+35 -2
Customize query in gerrit

Related Objects

Event Timeline

IKhitron created this task.Oct 18 2016, 3:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 18 2016, 3:30 PM
Aklapper added a comment.Oct 18 2016, 8:49 PM
IKhitron added a comment.Oct 19 2016, 12:02 PM

Well, @Aklapper, yes, yes, yes, and FF.49.0.1

Untitled.jpg (649×1 px, 295 KB)
Aklapper added a comment.Oct 19 2016, 12:59 PM

Hmm, why is your screenshot Left-To-Right (LTR) while he.wp is RTL? If you have specific settings in your preferences that might influence reproducing the problem, please share them in bug reports.

IKhitron added a comment.Oct 19 2016, 1:08 PM

No, @Aklapper, I just used uselang=en so you can read it.

IKhitron added a comment.Oct 21 2016, 7:43 PM

Hi, @Aklapper. I choosed in different account, without any gadgets or non default preferences or local js or css files - the same problem.

Aklapper added a comment.EditedOct 22 2016, 8:08 PM
  1. I am logged in, using Firefox 49, and use the Vector skin.
  2. I manually enabled "Group changes by page in recent changes and watchlist" on https://he.wikipedia.org/wiki/מיוחד:העדפות?uselang=en#mw-prefsection-rc . "Hide categorization of pages" was already enabled by default.
  3. I went to https://he.wikipedia.org/w/index.php?title=מיוחד:שינויים_אחרונים&hideWikibase=0&hidecategorization=0&uselang=en
  4. What I see:

w.png (418×1 px, 85 KB)
  1. This looks very different from your screenshot, for reasons that I do not know and need to be found out:

Untitled.jpg (649×1 px, 295 KB)

But I do not know what page your screenshot is taken from.

A list of exact steps, environment, and settings to reproduce is extremely welcome.

IKhitron added a comment.Oct 22 2016, 8:14 PM

@Aklapper, you are on the wrong page. It's watchlist, not recent changes. See the task title.

Aklapper added a comment.Oct 22 2016, 10:08 PM

Ah, thanks! The sentence "I always use grouping mode for watchlist and recent changes in preferences" tricked me, so I thought I can see it on both pages. My fault.

https://he.wikipedia.org/w/index.php?title=מיוחד:העדפות&uselang=en#mw-prefsection-watchlist does not show any option related to "grouping mode" hence I still do not know how to reproduce your view.

A numbered list of steps to reproduce that others can just follow is very welcome.

IKhitron added a comment.EditedOct 22 2016, 11:31 PM
  1. Open recent changes properties, #Aklapper.
  2. Turn on the first advanced feature - grouping mode fot recent changes and watchlist.
  3. Open Special:Watchlist.
  4. If Hide categorization radiobox in checked, uncheck it and click list rebuild button.
  5. And then check it again with the grouping mode in 1 turned off.
IKhitron added a comment.Oct 23 2016, 12:51 PM

@Aklapper, I checked in recent changes - same problem. I added in enwiki, where I do not work usually - same problem.

Aklapper added a comment.Oct 23 2016, 6:39 PM

Thanks! (For future reference, links are welcome :) )
Hmm, I'm afraid I cannot reproduce:

  1. I go to https://he.wikipedia.org/w/index.php?title=%D7%9E%D7%99%D7%95%D7%97%D7%93:%D7%94%D7%A2%D7%93%D7%A4%D7%95%D7%AA&uselang=en#mw-prefsection-rc
  2. Under "Advanced options", I enable "Group changes by page in recent changes and watchlist". I leave the three other options unchecked.
  3. I go to https://he.wikipedia.org/wiki/%D7%9E%D7%99%D7%95%D7%97%D7%93:%D7%A8%D7%A9%D7%99%D7%9E%D7%AA_%D7%94%D7%9E%D7%A2%D7%A7%D7%91?uselang=en
  4. I disable "page categorization"
  5. I click the "Show" button (which ignores that I added uselang=en to the URL earlier)
  6. I get this result:

x.png (688×1 px, 94 KB)
Aklapper renamed this task from Categorization in watchlist appears differently in grouping mode to Categorization in watchlist different in grouping mode: "( diff | history )" are plain text and no links.Oct 23 2016, 6:40 PM
IKhitron renamed this task from Categorization in watchlist different in grouping mode: "( diff | history )" are plain text and no links to Categorization in watchlist different in nongrouping mode: "( diff | history )" are plain text and no links.Oct 23 2016, 6:44 PM
IKhitron added a comment.Oct 23 2016, 6:48 PM

Hi, @Aklapper, once again:
the plain text is in nongrouping mode. I gave it to you to compare, but the problem is when "2"in your list is disabled.
There is no categorization in the watchlist you showed me. You need bigger watchlist, that has many categories. Try adding to your watchlist this category, it has 4 entries today, or this one, ut has 3 entries today.

Aklapper added a comment.Oct 23 2016, 6:49 PM

...and after performing step 5 "And then check it again with the grouping mode in 1 turned off." in T148533#2736348, the result here is:

x.png (691×1 px, 96 KB)
IKhitron added a comment.Oct 23 2016, 6:51 PM

Agauin, it's without categorization entries, @Aklapper. Star these two categories and refresh.

Aklapper added a comment.Oct 23 2016, 7:18 PM

Okay, I can reproduce, but what would you expect "diff" and "history" to actually link to?

IKhitron added a comment.Oct 23 2016, 7:21 PM

Great, @Aklapper. The same as in grouping mode, they work there. Try this category, it has one categorization entry today, so you'll see the links.

matej_suchanek edited projects, added CatWatch; removed MediaWiki-Categories.Aug 27 2017, 1:21 PM
Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptAug 27 2017, 1:21 PM
Addshore subscribed.Aug 28 2017, 10:34 AM

So as far as I can tell (from what I read above)

Per https://phabricator.wikimedia.org/T109688#1593043 the links were disabled when CatWatch was initially introduced.

My comment says this is essentially pending deciding what to link to.

Tobi_WMDE_SW moved this task from Incoming to Other on the TCB-Team (now WMDE-TechWish) board.Oct 10 2017, 9:48 AM
Etonkovidova subscribed.Dec 13 2017, 12:37 AM

I checked the steps described above - it does not make sense to have diff|history as plain text on Watchlist and as links, e.g. on Special:Related changes.

Watchlist-plain textRelated changes-links
Screen Shot 2017-12-12 at 4.02.06 PM.png (694×799 px, 140 KB)
Screen Shot 2017-12-12 at 4.02.27 PM.png (550×883 px, 151 KB)
Nardog subscribed.Sep 14 2020, 10:37 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 14 2020, 10:37 AM
Nardog renamed this task from Categorization in watchlist different in nongrouping mode: "( diff | history )" are plain text and no links to Categorization in watchlist different in nongrouping mode: "(diff | hist)" are plain text and no links.Oct 3 2020, 6:22 AM
Nardog added a project: MediaWiki-Recent-changes.
thiemowmde edited projects, added Regression, WMDE-TechWish-Maintenance; removed TCB-Team (now WMDE-TechWish).Nov 2 2020, 9:04 AM
Nardog mentioned this in T270662: Diff and history links missing for grouped category changes on Watchlist/RecentChanges.Dec 22 2020, 12:51 AM
MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:59 PM
Nardog mentioned this in T130134: Watching (only) categorization (additions and removals) of an arbitrary category.Oct 15 2021, 2:16 AM
Addshore unsubscribed.Jun 27 2023, 12:38 PM
KStoller-WMF removed projects: Growth-Team-Filtering, Growth-Team.Sep 13 2024, 5:42 PM
Samwalton9-WMF added a project: Moderator-Tools-Team.Mar 4 2025, 3:59 PM
Samwalton9-WMF moved this task from Inbox to To be estimated on the Moderator-Tools-Team board.
Samwalton9-WMF renamed this task from Categorization in watchlist different in nongrouping mode: "(diff | hist)" are plain text and no links to "(diff | hist)" are plain text and have no links for categorization entries in Recent Changes and Watchlist in non-grouping mode.Mar 4 2025, 4:14 PM
Samwalton9-WMF updated the task description. (Show Details)
Samwalton9-WMF updated the task description. (Show Details)
Samwalton9-WMF updated the task description. (Show Details)
Samwalton9-WMF updated the task description. (Show Details)Mar 4 2025, 4:17 PM
Kgraessle set the point value for this task to 5.Mar 4 2025, 4:17 PM
Kgraessle moved this task from To be estimated to Estimated on the Moderator-Tools-Team board.
Samwalton9-WMF updated the task description. (Show Details)Mar 4 2025, 4:18 PM
Samwalton9-WMF updated the task description. (Show Details)
DMburugu triaged this task as Low priority.Mar 4 2025, 5:13 PM
DMburugu raised the priority of this task from Low to Medium.
DMburugu moved this task from Estimated to Kanban on the Moderator-Tools-Team board.Mar 4 2025, 5:15 PM
DMburugu edited projects, added Moderator-Tools-Team (Kanban); removed Moderator-Tools-Team.
Kgraessle claimed this task.Mar 19 2025, 4:44 PM
Kgraessle moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.
Kgraessle added a subscriber: Samwalton9-WMF.EditedMar 20 2025, 3:52 PM

@Samwalton9-WMF it appears the link is not being created in the following scenarios:

  1. Recent change type is new
  2. Recent change type is log
  3. Recent change type is categorize

Link to code here.

This has been the case since 2015. Do we want to add the link for all rc_types above or just when it is a category?

Samwalton9-WMF added a comment.Mar 20 2025, 4:07 PM
In T148533#10657649, @Kgraessle wrote:

@Samwalton9-WMF it appears the link is not being created in the following scenarios:

  1. Recent change type is new
  2. Recent change type is log
  3. Recent change type is categorize

Link to code here.

This has been the case since 2015. Do we want to add the link for all rc_types above or just when it is a category?

Thanks for looking!

Definitely yes for case 3 (categories) given the prior art in T270662 for deciding where those should go.

For logs, I think I'm right in saying there aren't diff/hist links for log entries, so I think we can safely ignore this case:

Screenshot 2025-03-20 at 16.06.23.png (382×1 px, 229 KB)

For page creations there can't be a diff, but there could be a hist link. It looks like that's already being added, though, so we can probably also ignore this?

Screenshot 2025-03-20 at 16.07.08.png (1×1 px, 697 KB)
gerritbot added a comment.Mar 20 2025, 6:27 PM

Change #1129906 had a related patch set uploaded (by Kgraessle; author: Kgraessle):

[mediawiki/core@master] "(diff | hist)" are plain text and have no links for categorization entries in Recent Changes and Watchlist in non-grouping mode

https://gerrit.wikimedia.org/r/1129906

gerritbot added a project: Patch-For-Review.Mar 20 2025, 6:27 PM
Kgraessle moved this task from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.Mar 20 2025, 8:08 PM
Scardenasmolinar moved this task from Eng review to QA on the Moderator-Tools-Team (Kanban) board.Mar 25 2025, 5:23 PM
gerritbot added a comment.Mar 25 2025, 5:45 PM

Change #1129906 merged by jenkins-bot:

[mediawiki/core@master] "(diff | hist)" are plain text and have no links for categorization entries in Recent Changes and Watchlist in non-grouping mode

https://gerrit.wikimedia.org/r/1129906

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.23; 2025-04-01).Mar 25 2025, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 25 2025, 6:31 PM
Krinkle awarded a token.Mar 25 2025, 10:14 PM
Kgraessle moved this task from QA to Done on the Moderator-Tools-Team (Kanban) board.Apr 3 2025, 7:12 PM
Kgraessle closed this task as Resolved.Apr 14 2025, 2:17 PM
Nardog reopened this task as Open.Thu, Apr 24, 11:50 PM

"hist" is now not linked again.

Kgraessle moved this task from Done to In Progress on the Moderator-Tools-Team (Kanban) board.Fri, Apr 25, 1:43 PM
gerritbot added a comment.Fri, Apr 25, 4:03 PM

Change #1139089 had a related patch set uploaded (by Kgraessle; author: Kgraessle):

[mediawiki/core@master] "(diff | hist)" are plain text and have no links for categorization entries in Recent Changes and Watchlist in non-grouping mode - Fix the hist plain text message

https://gerrit.wikimedia.org/r/1139089

gerritbot added a project: Patch-For-Review.Fri, Apr 25, 4:03 PM
Kgraessle moved this task from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.Fri, Apr 25, 6:46 PM
PatchDemoBot added a comment.Fri, Apr 25, 6:46 PM

Test wiki created on Patch demo by KGraessle-WMF using patch(es) linked to this task:
https://patchdemo.wmcloud.org/wikis/104a9e8145/w/

PatchDemoBot added a comment.Fri, Apr 25, 6:51 PM

Test wiki on Patch demo by KGraessle-WMF using patch(es) linked to this task was deleted:

https://patchdemo.wmcloud.org/wikis/104a9e8145/w/

Scardenasmolinar moved this task from Eng review to QA on the Moderator-Tools-Team (Kanban) board.Tue, Apr 29, 12:47 AM
gerritbot added a comment.Tue, Apr 29, 1:08 AM

Change #1139089 merged by jenkins-bot:

[mediawiki/core@master] "(diff | hist)" are plain text and have no links for categorization entries in Recent Changes and Watchlist in non-grouping mode - Fix the hist plain text message

https://gerrit.wikimedia.org/r/1139089

Maintenance_bot removed a project: Patch-For-Review.Tue, Apr 29, 1:30 AM
ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.28; 2025-05-06); removed MW-1.44-notes (1.44.0-wmf.23; 2025-04-01).Tue, Apr 29, 2:00 AM
Kgraessle moved this task from QA to Done on the Moderator-Tools-Team (Kanban) board.Wed, May 7, 5:20 PM
jsn.sherman closed this task as Resolved.Thu, May 8, 4:35 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits