Page MenuHomePhabricator

Minerva footer hides new items by default
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Visit any page in Minerva skin
  • Run mw.util.addPortletLink('footer-places', '#', 'footer place link')

What happens?:
The newly added footer item is hidden by default

What should have happened instead?:
It should be visible

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Change #1118586 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@master] Footer: drop hacks for hiding items in the footer

https://gerrit.wikimedia.org/r/1118586

Jdlrobson-WMF renamed this task from Minerva footer to Minerva footer hides new items by default.Feb 24 2025, 5:47 PM

Change #1118586 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Footer: drop hacks for hiding items in the footer

https://gerrit.wikimedia.org/r/1118586

The new footer duplicates the privacy and terms links that are already in the mobile main menu

Screenshot 2025-02-27 at 3.24.49 PM.png (850×801 px, 140 KB)

The plan is to restore hiding these links in Minerva as part of T373208 (cc @LMora-WMF )

/** Hiding duplicate links that are already displayed in the main menu */
#footer-places-disclaimers, #footer-places-about { display: none; }

Change #1123693 had a related patch set uploaded (by Jdlrobson; author: LorenMora):

[mediawiki/skins/MinervaNeue@master] Update Minerva to include footer banners

https://gerrit.wikimedia.org/r/1123693

Change #1123693 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Update Minerva to include footer banners

https://gerrit.wikimedia.org/r/1123693

As a side effect of removing the troublesome hack, the bug in T387797 surfaced.