Skip to content

chore: make XCScheme static path functions public. #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 19, 2025
Merged

chore: make XCScheme static path functions public. #940

merged 2 commits into from
May 19, 2025

Conversation

trentguillory-gc
Copy link
Contributor

Resolves #939

Short description 📝

Static XCScheme functions intended to be public are internal. I made them public.

Solution 📦

Internal > Public

Implementation 👩‍💻👨‍💻

Not much to speak of here.

@pepicrft pepicrft changed the title Make XCScheme static path functions public. chore: make XCScheme static path functions public. May 16, 2025
@pepicrft
Copy link
Contributor

@trentguillory-gc would you mind running mise run lint-fix?

@trentguillory-gc
Copy link
Contributor Author

@pepicrft sure thing!

@trentguillory-gc
Copy link
Contributor Author

trentguillory-gc commented May 16, 2025 •
edited
Loading

Huh, this changes more than the files I touched @pepicrft. Is there somewhere I should go to get the right swiftformat config?

modified:   Sources/XcodeProj/Objects/Project/PBXObjects.swift
modified:   Sources/XcodeProj/Objects/Project/PBXProjEncoder.swift
modified:   Sources/XcodeProj/Scheme/XCScheme+LaunchAction.swift
modified:   Sources/XcodeProj/Scheme/XCScheme.swift
modified:   Sources/XcodeProj/Utils/ReferenceGenerator.swift
modified:   Tests/XcodeProjTests/Objects/BuildPhase/PBXBuildPhaseTests.swift
modified:   Tests/XcodeProjTests/Objects/Configuration/BuildFileSettingTests.swift
modified:   Tests/XcodeProjTests/Objects/Configuration/BuildSettingTests.swift
modified:   Tests/XcodeProjTests/Objects/Project/PBXProjObjectsHelpersTests.swift

@pepicrft
Copy link
Contributor

Is that with mise run lint-fix? I have the feeling the script is using a version other than the one the mise.toml points to.

@fortmarek
Copy link
Member

Thanks for the contribution!

@fortmarek fortmarek merged commit 5dce1ee into tuist:main May 19, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepicrft pepicrft pepicrft approved these changes

@fortmarek fortmarek fortmarek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XCScheme Static Path Methods are Internal
3 participants
@trentguillory-gc @pepicrft @fortmarek