chore: PHP CS Fixer and protected_to_private #62760
Merged
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
stof
reviewed
Dec 12, 2025
nicolas-grekas
force-pushed
the
6.4_protected_to_private
branch
from
3b050f2 to
c98b276
Compare
Member
|
Thank you @keradus. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rule aims to reduce visibility from protected to private, when protected visibility makes no sense (ie in final class).
The rule is widely followed by codebase.
I recommend enabling it (and adding to the Symfony ruleset), as it's followed in almost each file.
There is one file - CacheItem - tha actually relies on "protected" even if class is final, due to having them exposed when serializing.
There are 3 other files where I believe protected was used accidentally, let the CI verify.
update: CI is green
Alternative is to remove the rule to be mentioned at all in local repo config file.