[Form] do not use PHPUnit mock objects without configured expectations #62759
+61
−76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Dec 12, 2025
xabbuh
commented
| Q | A |
|---|---|
| Branch? | 6.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Issues | part of #62669 |
| License | MIT |
7 tasks
| $metadata = $this->getMockBuilder(ClassMetadata::class)->setConstructorArgs([''])->onlyMethods(['addPropertyConstraint'])->getMock(); | ||
| $this->validator->expects($this->any())->method('getMetadataFor')->willReturn($metadata); | ||
| $this->validator->expects($this->any())->method('validate')->willReturn(new ConstraintViolationList()); | ||
| $this->validator = (new ValidatorBuilder())->getValidator(); |
Contributor
There was a problem hiding this comment.
Since the validator is protected, someone could add expections $this->validator->method(...) when using the trait.
So is this change considered as a BC break ?
Member
Author
There was a problem hiding this comment.
I won't consider this a BC break as the type of the property is ValidatorInterface. In other places where we communicated the type to be MockObject I kept it.
Member
There was a problem hiding this comment.
Would keeping the mock be problematic? Symfony is widely used enough for someone to be affected by this ;)
| parent::setUp(); | ||
|
|
||
| $this->dispatcher = $this->createMock(EventDispatcherInterface::class); | ||
| $this->dispatcher = new EventDispatcher(); |
Contributor
There was a problem hiding this comment.
Same here, the dispatcher is protected so someone could have added expectation on the dispatcher in his tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.