[Mailer] do not use PHPUnit mock objects without configured expectations #62756
+15
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Dec 12, 2025
xabbuh
commented
| Q | A |
|---|---|
| Branch? | 6.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Issues | part of #62669 |
| License | MIT |
xabbuh
force-pushed
the
issue-62669-mailer
branch
from
8115e87 to
b5dbe6a
Compare
xabbuh
force-pushed
the
issue-62669-mailer
branch
from
b5dbe6a to
494fa91
Compare
nicolas-grekas
approved these changes
Dec 12, 2025
Member
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
🎉 thanks for working on this!
7 tasks
stof
approved these changes
Dec 12, 2025
Comment on lines
106
to
109
| protected function getDispatcher(): EventDispatcherInterface | ||
| { | ||
| return $this->dispatcher ??= $this->createMock(EventDispatcherInterface::class); | ||
| return $this->dispatcher ??= new EventDispatcher(); | ||
| } |
Contributor
There was a problem hiding this comment.
What was the use case of those protected method ?
Cause if someone did
$this->getDispatcher->expect(self::once())->method('dispatch');
This won't work anymore (so could be called a BC break ?)
Member
Author
There was a problem hiding this comment.
The return type of the method is EventDispatcherInterface. If you want still use a mock object, you can override the method.
fabpot
approved these changes
Dec 14, 2025
Member
|
Thank you @xabbuh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.