Skip to content

[ObjectMapper] Tag MapCollection as a service #62746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
damienfern wants to merge 1 commit into
base: 8.1
Choose a base branch
from
Open

[ObjectMapper] Tag MapCollection as a service #62746

damienfern wants to merge 1 commit into from
+8 −0

Conversation

@damienfern
Copy link
Contributor

@damienfern damienfern commented Dec 11, 2025

Q A
Branch? 8.1
Bug fix? no
New feature? yes
Deprecations? no
License MIT

From the docs, if you want to map an array, you need to use the MapCollection class :

use Symfony\Component\ObjectMapper\Attribute\Map;
use Symfony\Component\ObjectMapper\Transform\MapCollection;

class ProductListInput
{
    #[Map(transform: new MapCollection())]
    /** @var ProductInput[] */
    public array $products;
}

But when doing so, the MapCollection class doesn't use the ObjectMapper registered in the container and instantiate a new one.

With this PR, you will map iterable like this :

use Symfony\Component\ObjectMapper\Attribute\Map;
use Symfony\Component\ObjectMapper\Transform\MapCollection;

class ProductListInput
{
    #[Map(transform: 'object_mapper.transform.map_collection')]
    /** @var ProductInput[] */
    public array $products;
}

A current workaround is to register the service in your own services.yaml :

    object_mapper.transform.map_collection:
        class: Symfony\Component\ObjectMapper\Transform\MapCollection
        arguments:
            - '@object_mapper'

I didn't know how to add tests for this, so any suggestion is welcome :)

All credit goes to @soyuka who gave the idea in the Symfony Slack !

@carsonbot carsonbot added this to the 8.1 milestone Dec 11, 2025
soyuka
soyuka suggested changes Dec 13, 2025
View reviewed changes
Copy link
Contributor

@soyuka soyuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing a test in the framework bundle

src/Symfony/Bundle/FrameworkBundle/Resources/config/object_mapper.php
->tag('object_mapper.transform_callable')
->args([
service('object_mapper'),
])
Copy link
Contributor

@soyuka soyuka Dec 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably add an alias to MapCollection::class so that we can use it instead of the service name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@soyuka soyuka soyuka requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature ObjectMapper Status: Needs Work

Projects

None yet

Milestone

8.1

Development

Successfully merging this pull request may close these issues.

3 participants

@damienfern @soyuka @carsonbot