[Validator] do not use PHPUnit mock objects without configured expectations #62745
+84
−101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Dec 11, 2025
xabbuh
commented
| Q | A |
|---|---|
| Branch? | 6.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Issues | part of #62669 |
| License | MIT |
stof
reviewed
Dec 11, 2025
src/Symfony/Component/Validator/Test/ConstraintValidatorTestCase.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Validator/Tests/Constraints/NotCompromisedPasswordValidatorTest.php
Outdated
Show resolved
Hide resolved
xabbuh
force-pushed
the
issue-62669-validator
branch
2 times, most recently
from
6f7ec8e to
27463a1
Compare
derrabus
reviewed
Dec 12, 2025
7 tasks
derrabus
approved these changes
Dec 12, 2025
| TXT | ||
| , $tester->getDisplay(true) | ||
| TXT, $tester->getDisplay(true) |
Member
There was a problem hiding this comment.
these should be reverted: CS has been fixed differently in 7.4, better not get needless conflicts
xabbuh
force-pushed
the
issue-62669-validator
branch
from
27463a1 to
36bc6a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.