[HttpClient] CachingHttpClient must run after UriTemplate and Scoping #62652
+13
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
force-pushed
the
fix/http-client/priorities
branch
from
5a365fa to
97d0b43
Compare
nicolas-grekas
approved these changes
Dec 4, 2025
Member
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
(I applied my suggestion)
stof
approved these changes
Dec 4, 2025
nicolas-grekas
force-pushed
the
fix/http-client/priorities
branch
from
97d0b43 to
4bb94a7
Compare
Member
|
Thank you @Lctrs. |
Contributor
Author
|
@nicolas-grekas Caching should occur after Retry to handle potential cache inconsistencies. Also, is it worth Throttling a request if we have a cache entry for it ? 🤔 |
Member
|
If there's a separate concern, we can discuss it on another PR/issue. The linked issue is now fixed, with the originally intended order :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CachingHttpClient needs the final resolved URL (base_uri from ScopingHttpClient + expanded URI templates) to compute correct cache keys.