[HttpClient] Fix sharing CurlClientState between clones of CurlHttpClient instances #62645
+106
−89
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #54207 fixed descriptor exhaustion for apps that never issued HTTP calls, but it inadvertently broke the sharing of Curl state between cloned/scoped clients. Any place that pre-creates lots of withOptions() variants before the first real request will now instantiate a separate CurlClientState per variant, leaking curl multi handles relative to previous releases. The fix restores state sharing so multiple clones can still point to the same CurlClientState while maintaining the “only allocate when someone actually sends a request” behavior.
That's the only thing I could think of that'd explain #62633
/cc @jwage can you give this a try?