[Form] Clean up wrong method docblocks in data transformers #62607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
xabbuh
reviewed
Dec 1, 2025
src/Symfony/Component/Form/Extension/Core/DataTransformer/ArrayToPartsTransformer.php
Outdated
Show resolved
Hide resolved
...ny/Component/Form/Extension/Core/DataTransformer/DateTimeToHtml5LocalDateTimeTransformer.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Form/Extension/Core/DataTransformer/DateTimeToRfc3339Transformer.php
Outdated
Show resolved
Hide resolved
carsonbot
changed the title
stof
approved these changes
Dec 2, 2025
yceruto
approved these changes
Dec 2, 2025
Member
|
Thank you @alexndlm. |
nicolas-grekas
force-pushed
the
feature/clean-up-wrong-method-docblocks-in-data-transformers-new
branch
from
4763f3f to
269dc4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the redundant and often incorrect docblocks from transform() and reverseTransform() methods in data transformers. These PHPDocs duplicate the interface, break generics, and add unnecessary noise.
Additionally, parameter names are updated to match those defined in DataTransformerInterface, ensuring consistency across all implementations.