[DependencyInjection][FrameworkBundle] fix BC break when dumping container for build/lint commands #62586
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Failing tests seem unrelated to me |
stof
reviewed
Dec 1, 2025
| $container->setDefinitions($dumpedContainer->getDefinitions()); | ||
| $container->setAliases($dumpedContainer->getAliases()); | ||
| $container->__construct($dumpedContainer->getParameterBag()); | ||
| $container->setParameterBag($dumpedContainer->getParameterBag()); |
Member
There was a problem hiding this comment.
I'd rather not add a new method. Can't we use a foreach instead, copying all parameters one by one?
Contributor
Author
There was a problem hiding this comment.
Not sure how a foreach would work? Would you use reflections instead?
Member
There was a problem hiding this comment.
can't we iterate over the parameters from the bag of the dumped container and call set() on the bag from the empty one?
Contributor
Author
There was a problem hiding this comment.
Ah yes, that could work as well! I'll investigate
Contributor
Author
There was a problem hiding this comment.
Changed in 02551f3. This would fail if we have a FrozenParameterBag, but I don't think that is ever the case as long as the container is not compiled.
…ainer for build/lint commands
nicolas-grekas
force-pushed
the
fix/container-constructor
branch
from
02551f3 to
843fbca
Compare
Member
|
Thank you @aschempp. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#60597 introduced a BC break in that it assumes the
ContainerBuilderconstructor accepts the parameter bag as its first argument. However, in our application, we have a custom version of theContainerBuilder.Since the container is already built at this state, I understand that calling
__construct()again is just a hack to re-set the parameter bag. A direct setter function for this case should fix the issue.PS:
Kernel::buildContainermust always return an instance ofContainerBuilder, so the setter method must always be there (our class inherits from it as well).Links:
ContainerBuilderindevcontao/contao#9058ContainerBuilderhttps://github.com/contao/manager-plugin/blob/main/src/Config/ContainerBuilder.php