Skip to content

[Console] Fix profile invokable command #62571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fabpot merged 1 commit into from
Nov 29, 2025
Merged

[Console] Fix profile invokable command #62571

fabpot merged 1 commit into from
Nov 29, 2025
+15 −3

Conversation

@Jibbarth
Copy link
Contributor

@Jibbarth Jibbarth commented Nov 29, 2025

Q A
Branch? 7.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #...
License MIT

Hello,

I noticed that, when I try to profile an invokable command on 7.4, it raise the following exception :

[critical] Uncaught Error: ReflectionFunction::__construct(): Argument #1 ($function) must be of type Closure|string, App\Command\MyAwesomeCommand given
TypeError {#199
  #message: "ReflectionFunction::__construct(): Argument #1 ($function) must be of type Closure|string, App\Command\MyAwesomeCommand given"
  #code: 0
  #file: "./vendor/symfony/console/Command/TraceableCommand.php"
  #line: 172
  trace: {
    ./vendor/symfony/console/Command/TraceableCommand.php:172 { …}
    ./vendor/symfony/console/Command/TraceableCommand.php:71 { …}
    ./vendor/symfony/framework-bundle/Console/Application.php:115 { …}
    ./vendor/symfony/console/Application.php:356 { …}
    ./vendor/symfony/framework-bundle/Console/Application.php:77 { …}
    ./vendor/symfony/console/Application.php:195 { …}
    ./vendor/symfony/runtime/Runner/Symfony/ConsoleApplicationRunner.php:49 { …}
    ./vendor/autoload_runtime.php:32 { …}
    ./bin/console:15 {

The invokableCommand class changed, the code attribute doesn't longer contains the closure to code.
Let's use the $invokableCommand->invokable instead that contains the reflectionFunction needed.

@Jibbarth Jibbarth requested a review from chalasr as a code owner November 29, 2025 12:02
@carsonbot carsonbot added this to the 7.4 milestone Nov 29, 2025
@Jibbarth Jibbarth force-pushed the fix/profile-invokable-command branch from c873849 to 4643bf1 Compare November 29, 2025 12:04
GromNaN
GromNaN requested changes Nov 29, 2025
View reviewed changes
@fabpot
Copy link
Member

fabpot commented Nov 29, 2025

Thank you @Jibbarth.

@fabpot fabpot merged commit cbe797f into symfony:7.4 Nov 29, 2025
3 of 12 checks passed
@Jibbarth Jibbarth deleted the fix/profile-invokable-command branch November 29, 2025 17:57
@xabbuh xabbuh mentioned this pull request Dec 3, 2025
Closed
This was referenced Dec 7, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabpot fabpot fabpot approved these changes

@GromNaN GromNaN GromNaN approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees

No one assigned

Labels

Bug Console Status: Reviewed

Projects

None yet

Milestone

7.4

Development

Successfully merging this pull request may close these issues.

4 participants

@Jibbarth @fabpot @GromNaN @carsonbot