[DependencyInjection] Reset resolved state when setting a parameter #62541
+18
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoeunes
force-pushed
the
di-parameter-bag-resolved-state
branch
from
dfd97a3 to
ad3b789
Compare
xabbuh
approved these changes
Nov 28, 2025
Member
|
Thank you @yoeunes. |
nicolas-grekas
added a commit
to nicolas-grekas/symfony
that referenced
this pull request
Dec 5, 2025
Member
|
Reverted in #62665 |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 5, 2025
…ate when setting a parameter" (nicolas-grekas) This PR was merged into the 6.4 branch. Discussion ---------- [DependencyInjection] Revert "bug #62541 Reset resolved state when setting a parameter" | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #62541 | License | MIT This reverts commit 808365f, reversing changes made to 3678f5c. PR #62541 introduced this. But the change makes the CI red on 7.3. And looking at the code again, changing the "resolved" state means already resolved parameters are going to be resolved twice. We could eg resolve immediately when setting a new value inside a resolved bag. I didn't do it since things were working before so I see no hurry to think about how to fix the fix. I prefer reverting for now. /cc `@yoeunes` FYI Commits ------- f4e6e99 Revert "bug #62541 [DependencyInjection] Reset resolved state when setting a parameter (yoeunes)"
nicolas-grekas
added a commit
that referenced
this pull request
Dec 5, 2025
* 6.4: Revert "bug #62541 [DependencyInjection] Reset resolved state when setting a parameter (yoeunes)"
nicolas-grekas
added a commit
that referenced
this pull request
Dec 5, 2025
* 7.3: Revert "bug #62541 [DependencyInjection] Reset resolved state when setting a parameter (yoeunes)"
nicolas-grekas
added a commit
that referenced
this pull request
Dec 5, 2025
* 7.4: Fix merge [HttpKernel] Make `#[Cache]` respect all explicit cache directives set in controller Revert "bug #62541 [DependencyInjection] Reset resolved state when setting a parameter (yoeunes)"
nicolas-grekas
added a commit
that referenced
this pull request
Dec 5, 2025
* 8.0: Fix merge [HttpKernel] Make `#[Cache]` respect all explicit cache directives set in controller Revert "bug #62541 [DependencyInjection] Reset resolved state when setting a parameter (yoeunes)"
This was referenced Dec 7, 2025
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a parameter containing placeholders to an already resolved bag resulted in the bag remaining marked as resolved, preventing the new parameter from being resolved.
This PR ensures that
ParameterBagmarks itself as unresolved when a new parameter is set.