-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[Notifier][Mercure] Add support for Mercure 0.7 #62524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey! Thanks for your PR. You are targeting branch "8.1" but it seems your PR description refers to branch "8.1 for features / 6.4, 7.3, 7.4, 8.0 for bug fixes". Cheers! Carsonbot |
|
Failing checks are unrelated |
|
I'd be fine having this on a lower branch like we do for Doctrine eg |
|
Like 7.3? |
fabpot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge it in 7.3
|
@Kocal Can you rebase the PR? |
|
@fabpot PR rebased |
xabbuh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also update constraint for MercureBundle in the main composer.json file to ^0.3|^0.4?
|
Thank you @Kocal. |
This PR was merged into the 7.3 branch. Discussion ---------- allow the installation of MercureBundle 0.4 | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | completing #62524 | License | MIT Commits ------- e4b5382 allow the installation of MercureBundle 0.4
cc @mtarld @dunglas