Skip to content

Conversation

@Kocal
Copy link
Member

@Kocal Kocal commented Nov 26, 2025

Q A
Branch? 7.3
Bug fix? no
New feature? yes
Deprecations? no
Issues Fix #...
License MIT

cc @mtarld @dunglas

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "8.1" but it seems your PR description refers to branch "8.1 for features / 6.4, 7.3, 7.4, 8.0 for bug fixes".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@carsonbot carsonbot added this to the 8.1 milestone Nov 26, 2025
@Kocal
Copy link
Member Author

Kocal commented Nov 27, 2025

Failing checks are unrelated

@nicolas-grekas
Copy link
Member

I'd be fine having this on a lower branch like we do for Doctrine eg

@Kocal
Copy link
Member Author

Kocal commented Nov 27, 2025

Like 7.3?
Support for Mercure 0.6 was added in 7.2

Copy link
Member

@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge it in 7.3

@fabpot fabpot modified the milestones: 8.1, 7.3 Nov 29, 2025
@fabpot
Copy link
Member

fabpot commented Nov 29, 2025

@Kocal Can you rebase the PR?

@Kocal
Copy link
Member Author

Kocal commented Nov 29, 2025

@fabpot PR rebased

Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also update constraint for MercureBundle in the main composer.json file to ^0.3|^0.4?

@fabpot
Copy link
Member

fabpot commented Nov 30, 2025

Thank you @Kocal.

@fabpot fabpot merged commit 93910ab into symfony:7.3 Nov 30, 2025
4 of 11 checks passed
@Kocal Kocal deleted the patch-1 branch November 30, 2025 20:49
nicolas-grekas added a commit that referenced this pull request Dec 2, 2025
This PR was merged into the 7.3 branch.

Discussion
----------

 allow the installation of MercureBundle 0.4

| Q             | A
| ------------- | ---
| Branch?       | 7.3
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | completing #62524
| License       | MIT

Commits
-------

e4b5382 allow the installation of MercureBundle 0.4
This was referenced Dec 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants