[DependencyInjection] Fix query_string env processor for URLs without query string
#62506
+21
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
Nov 25, 2025
src/Symfony/Component/DependencyInjection/Tests/EnvVarProcessorTest.php
Outdated
Show resolved
Hide resolved
yoeunes
force-pushed
the
fix-di-query-string-urls
branch
from
6ac5f4f to
160614c
Compare
nicolas-grekas
force-pushed
the
fix-di-query-string-urls
branch
from
160614c to
69ad606
Compare
Member
|
Thank you @yoeunes. |
This was referenced Dec 7, 2025
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
%env(query_string:MY_URL)%with a URL that has no query string (e.g.https://example.com), the processor currently falls back toparse_str('https://example.com', $result).This PR ensures that
[]is returned when the input is a valid URL but lacks a query component.