[Security][Http] Fix OIDC discovery when multiple HttpClient instances are used #62495
+100
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ali-HENDA
force-pushed
the
fix/oidc-jwks-streaming
branch
from
ae5e619 to
561d8b4
Compare
stof
reviewed
Nov 24, 2025
src/Symfony/Component/Security/Http/AccessToken/Oidc/OidcTokenHandler.php
Outdated
Show resolved
Hide resolved
Ali-HENDA
force-pushed
the
fix/oidc-jwks-streaming
branch
from
561d8b4 to
7c7b38b
Compare
Ali-HENDA
force-pushed
the
fix/oidc-jwks-streaming
branch
from
7c7b38b to
7a885d2
Compare
Member
|
Thank you @Ali-HENDA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in the OIDC JWKS discovery logic revealed in the discussion of #62369.
$client->stream() was used incorrectly:
$client could be undefined, and responses must be streamed using the same client instance that created them, which breaks when multiple HttpClientInterface instances are configured.
The logic now performs sequential discovery per client, avoiding cross-client streaming and ensuring correctness.
This PR also hardens the "use" check ($key['use'] ?? null).