[Cache] Recognize saveDeferred events as writes in CacheDataCollector
#62372
+42
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Component/Cache/DataCollector/CacheDataCollector.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
requested review from
chalasr,
dunglas,
lyrixx,
xabbuh and
yceruto
as code owners
nicolas-grekas
force-pushed
the
cache_data_collector_commit
branch
from
4bf7788 to
77cfbdf
Compare
nicolas-grekas
approved these changes
Nov 13, 2025
Member
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
(I've squashed and rebased for 6.4)
yitznewton
changed the title
CacheDataCollectorCacheDataCollector
Member
|
Thank you @yitznewton. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not find any issues relating to this change.
Currently,
CacheDataCollectordoes not increment any counter on calls to eitherCacheItemPoolInterface::saveDeferred()orCacheItemPoolInterface::commit().With this PR, we continue to ignore
saveDeferred(), but now treat each call tocommit()as one write, regardless of the success or failure of the call, similar to the current behavior withsave().I added a test for the unchanged behavior on
saveDeferred()to make that behavior explicit.