[ExpressionLanguage] Compile numbers with var_export in Compiler::repr for thread-safety #62350
+28
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r for thread-safety
nicolas-grekas
approved these changes
Nov 11, 2025
xabbuh
approved these changes
Nov 11, 2025
Member
|
Thank you @yoeunes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suggests replacing the
setlocale()logic inCompiler::repr()withvar_export()when compiling numbers.The current use of
setlocale()is not thread-safe and can cause race conditions in concurrent environments (e.g., Swoole, RoadRunner).var_export()is locale-independent, thread-safe, and correctly handles all required float formats (3.3,42.0,1.0E-6,INF,NAN), as confirmed by the expanded test suite.