[OptionsResolver] Ensure remove() also unsets deprecation status #62347
+30
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
approved these changes
Nov 8, 2025
nicolas-grekas
approved these changes
Nov 11, 2025
Member
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
Some nitpicks but GTM otherwise.
src/Symfony/Component/OptionsResolver/Tests/OptionsResolverTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/OptionsResolver/Tests/OptionsResolverTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/OptionsResolver/Tests/OptionsResolverTest.php
Outdated
Show resolved
Hide resolved
yoeunes
force-pushed
the
options-resolver-remove-deprecation
branch
from
d50c74d to
5ffa260
Compare
Contributor
Author
|
Hi @nicolas-grekas, Thanks for the review! I've just applied your suggestions 🙏🏼 |
GromNaN
approved these changes
Nov 11, 2025
xabbuh
approved these changes
Nov 12, 2025
Member
|
Thank you @yoeunes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures
remove()fully clears an option, including any deprecation, allowing clean overrides in child configs (as suggested by @yceruto in #62345).