[Clock] Align MockClock::sleep() behavior with NativeClock for negative values #62346
+14
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a behavioral inconsistency between
NativeClockandMockClockwhen handling negative sleep durations.The Problem:
NativeClock::sleep(-10): Silently does nothing. The time does not change.MockClock::sleep(-10): Travels backward in time by 10 seconds.This inconsistency can lead to unreliable tests, as the mock does not accurately represent the real implementation's behavior for this edge case.
The Fix:
This fix adds a guard clause to
MockClock::sleep()to ignore any duration less than or equal to zero, perfectly matching the behavior ofNativeClock.Before (The Bug):
After (The Fix):