[OptionsResolver] Fix missing prototype key in nested error paths #62344
+47
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where
MissingOptionsExceptionerror messages for nested prototypes generated an incomplete path. When an option was missing inside a prototype that was itself nested inside another prototype, the key of the parent prototype was omitted from the error message.The fix ensures the parent's prototype index is correctly tracked and prepended when resolving nested options, providing a full and accurate path for easier debugging.
Example:
Given the following nested prototype setup:
And this configuration, which is missing a
hostinmain_db's second replica:Before (The Bug):
The exception message was incorrect, missing the
main_dbkey:The required option "connections[replicas][1][host]" is missing.After (The Fix):
The exception message is now correct and includes the full path:
The required option "connections[main_db][replicas][1][host]" is missing.A test case (
testNestedPrototypeErrorPathHasFullContext) has been added to cover this scenario and prevent regressions.