[Console] Fix signal handlers not being cleared after command termination #62335
+310
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for your PR. You are targeting branch "7.3" but it seems your PR description refers to branch " Cheers! Carsonbot |
yoeunes
force-pushed
the
console-signal-handler-leak
branch
7 times, most recently
from
3924c80 to
b88619d
Compare
Member
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
Please rebase/retarget for 6.4 since that's a bugfix that applies there.
src/Symfony/Component/Console/SignalRegistry/SignalRegistry.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Console/SignalRegistry/SignalRegistry.php
Outdated
Show resolved
Hide resolved
yoeunes
force-pushed
the
console-signal-handler-leak
branch
from
b88619d to
2fd421b
Compare
yoeunes
force-pushed
the
console-signal-handler-leak
branch
from
2fd421b to
559e878
Compare
nicolas-grekas
approved these changes
Nov 12, 2025
nicolas-grekas
force-pushed
the
console-signal-handler-leak
branch
from
559e878 to
6731fff
Compare
Member
|
Thank you @yoeunes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where signal handlers would leak in long-running processes (e.g., Scheduler). When the same command was run multiple times, handlers would accumulate, causing a single OS signal to be handled repeatedly.