[PropertyInfo] Fix ReflectionExtractor handling of underscore-only property names
#62334
+90
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoeunes
force-pushed
the
propertyinfo-underscore-camelize
branch
from
901781e to
34605d0
Compare
Member
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
please remove most/all comments, unless they really provide value
src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php
Outdated
Show resolved
Hide resolved
yoeunes
force-pushed
the
propertyinfo-underscore-camelize
branch
3 times, most recently
from
cf5fa78 to
f98b0ed
Compare
OskarStark
changed the title
ReflectionExtractor handling of underscore-only property names
OskarStark
reviewed
Nov 12, 2025
src/Symfony/Component/PropertyInfo/Tests/Fixtures/UnderscoreDummy.php
Outdated
Show resolved
Hide resolved
yoeunes
force-pushed
the
propertyinfo-underscore-camelize
branch
from
f98b0ed to
1a877f4
Compare
Member
|
Thank you @yoeunes. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 13, 2025
…p since PHP 8.1 (xabbuh) This PR was merged into the 6.4 branch. Discussion ---------- [PropertyInfo] ReflectionMethod::setAccessible() is no-op since PHP 8.1 | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT added in #62334, this allows to entirely remove it after merging into `7.3` like we did everywhere else Commits ------- ef9e803 ReflectionMethod::setAccessible() is no-op since PHP 8.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in
ReflectionExtractor::camelizewhere property names consisting only of underscores (e.g.,$_) were incorrectly transformed into an empty string.This caused
getReadInfoto fail when finding the corresponding accessor (e.g.,get_()), preventing the property from being detected, which impacts serialization and other component usages.