Skip to content

[Routing] Fix default value not taken if usigng name:entity.attribute #62325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicolas-grekas merged 1 commit into from
Nov 12, 2025
Merged

[Routing] Fix default value not taken if usigng name:entity.attribute #62325

nicolas-grekas merged 1 commit into from
Nov 12, 2025
+19 −4

Conversation

@eltharin
Copy link
Contributor

@eltharin eltharin commented Nov 6, 2025

Q A
Branch? 7.3
Bug fix? yes
New feature? no
Deprecations? no
Issues
License MIT

When using Mapped parameters, default values can't be used :

    #[Route('/zoom/{vortexLibelle:vortex.libelle}/{libelle:otherVortex}', name: 'zoom', methods: ['GET'])]
    #[AjaxCallOrNot]
    public function zoom(VortexManager $vr, Vortex $vortex, ?Vortex $otherVortex = null): Response
    {
        ...
    }

or

    #[Route('/zoom/{vortexLibelle:vortex.libelle}/{otherVortexLibelle:otherVortex.libelle}', name: 'zoom', methods: ['GET'])]
    #[AjaxCallOrNot]
    public function zoom(VortexManager $vr, Vortex $vortex, ?Vortex $otherVortex = null): Response
    {
        ...
    }

route was not found if we want to go to : /zoom/myVortex,

with this fix, it's OK

@carsonbot carsonbot added this to the 7.3 milestone Nov 6, 2025
@carsonbot carsonbot changed the title correct bug for default value not taken if usigng name:entity.attribute correct bug for default value not taken if usigng name:entity.attribute Nov 6, 2025
@xabbuh xabbuh added the Routing label Nov 6, 2025
@carsonbot carsonbot changed the title correct bug for default value not taken if usigng name:entity.attribute [Routing] correct bug for default value not taken if usigng name:entity.attribute Nov 6, 2025
@eltharin eltharin changed the title [Routing] correct bug for default value not taken if usigng name:entity.attribute [Routing] Fix default value not taken if usigng name:entity.attribute Nov 6, 2025
nicolas-grekas
nicolas-grekas reviewed Nov 6, 2025
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about the logic for backed enums in the previous block? don't we need something similar?

@eltharin eltharin force-pushed the error_default_route_argument_with_complete_notation branch from 6a89ac7 to f5077aa Compare November 6, 2025 16:28
@eltharin
Copy link
Contributor Author

eltharin commented Nov 6, 2025 •
edited
Loading

I write on my todolist to allow mapped parameters notation to use BackedEnum::from :)

nicolas-grekas
nicolas-grekas reviewed Nov 6, 2025
View reviewed changes
@eltharin eltharin force-pushed the error_default_route_argument_with_complete_notation branch from a916fc7 to 613acce Compare November 6, 2025 16:43
@nicolas-grekas nicolas-grekas force-pushed the error_default_route_argument_with_complete_notation branch from 613acce to f7c898f Compare November 12, 2025 16:36
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Nov 12, 2025

Thank you @eltharin.

@nicolas-grekas nicolas-grekas merged commit 206351d into symfony:7.3 Nov 12, 2025
9 checks passed
This was referenced Nov 13, 2025
Merged
Merged
@fabpot fabpot mentioned this pull request Dec 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees

No one assigned

Labels

Bug Routing Status: Reviewed

Projects

None yet

Milestone

7.3

Development

Successfully merging this pull request may close these issues.

4 participants

@eltharin @nicolas-grekas @xabbuh @carsonbot