[DependencyInjection] Fix lazy proxy creation for interfaces aliased to final classes #62304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Nov 4, 2025
src/Symfony/Component/DependencyInjection/Tests/Compiler/AutowirePassTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Tests/Compiler/AutowirePassTest.php
Outdated
Show resolved
Hide resolved
yoeunes
force-pushed
the
di-lazy-proxy-final-class-7.3
branch
from
18542bd to
2151173
Compare
Contributor
Author
|
Hi @stof, thanks for the review! I've updated the PR to always resolve aliases for lazy proxies when possible, but fallback to the original type (e.g., interface) for final classes on PHP < 8.4 to avoid proxy errors. Tests now pass on PHP 8.2 and 8.4 without restrictions. (cc @nicolas-grekas) |
yoeunes
force-pushed
the
di-lazy-proxy-final-class-7.3
branch
6 times, most recently
from
ef0cdca to
58e136a
Compare
Contributor
Author
|
I've just pushed an update to refactor the logic to simplify the |
yoeunes
force-pushed
the
di-lazy-proxy-final-class-7.3
branch
from
58e136a to
27daa84
Compare
nicolas-grekas
force-pushed
the
di-lazy-proxy-final-class-7.3
branch
from
27daa84 to
3dcc31b
Compare
Member
|
Thank you @yoeunes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where autowiring a lazy dependency for an interface (e.g.,
#[Autowire(lazy: true)] TestInterface) would fail if that interface was aliased to afinalclass.The
AutowirePasswas attempting to resolve the alias to the concretefinalclass, which causes a fatal error on PHP < 8.4 asfinalclasses cannot be proxied.This fix updates the logic to:
final, fall back to proxying the original type-hint (the interface) to avoid the fatal error.Tests have been updated to cover these scenarios and now pass on all PHP versions without restrictions.