stream.hls: refactor playlist reload #6347
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor HLSStreamWorker: - Rename reload_playlist() to reload() - Rename _playlist_reload_time() to _get_reload_time() - Rename playlist_reload_last to _reload_last - Rename playlist_reload_time to _reload_time - Rename playlist_reload_time_override to _reload_time_override - Rename playlist_reload_retries to _reload_retries - TestHlsPlaylistReloadTime: - Rename to TestHlsReloadTime - Remove prefixes of various test method names - TestMixinStreamHLS: - Rename await_playlist_reload() to await_reload()
Refactor `HLSStreamWorker` and move polling wait-time logic into `PollingSegmentedStreamWorker`, so it can be re-used in other segmented stream types eventually, like in DASH for example.
Move logic for stopping the stream early if no new segments were queued in a specific time frame from `HLSStreamWorker` to `PollingSegmentedStreamWorker`, and simplify attribute+method names.
Move segment gap warning from `HLSStreamWorker` to `PollingSegmentedStreamWorker`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6340
Opening this as a draft for now, as it's WIP and unfinished. This simply moves stuff into a new intermediate abstract base class,
PollingSegmentedStreamWorker, and it simplifies attribute and method names.I currently don't know if this requires further changes, as I haven't had a look at the
DASHStreamWorkeryet, which is supposed to utilize the shared code here in the future.Another thing that's missing, but could be changed later, is renaming the
hls-segment-queue-thresholdsession option and CLI argument, as it's now part of the shared base class. A good opportunity for choosing a better name, e.g.segmented-queue-deadlineor something like that.