plugins.bloomberg: add webbrowser API fallback #6107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gravyboat
approved these changes
Aug 3, 2024
bastimeyer
force-pushed
the
plugins/bloomberg/webbrowser
branch
from
d0e7869 to
d310fc1
Compare
This was referenced Aug 7, 2024
Merged
|
Doesn't work for me on Linux or Windows. I seem to get a bot protection captcha that breaks the script. $ streamlink --webbrowser-executable "C:\Program Files\Google\Chrome\Application\chrome.exe" -l debug https://www.bloomberg.com/live best
[session][debug] Loading plugin: bloomberg
[cli][debug] OS: Windows 10
[cli][debug] Python: 3.12.1
[cli][debug] OpenSSL: OpenSSL 3.0.11 19 Sep 2023
[cli][debug] Streamlink: 6.8.3+31.gd310fc18
[cli][debug] Dependencies:
[cli][debug] certifi: 2024.7.4
[cli][debug] isodate: 0.6.1
[cli][debug] lxml: 5.2.2
[cli][debug] pycountry: 24.6.1
[cli][debug] pycryptodome: 3.20.0
[cli][debug] PySocks: 1.7.1
[cli][debug] requests: 2.32.3
[cli][debug] trio: 0.26.2
[cli][debug] trio-websocket: 0.11.1
[cli][debug] typing-extensions: 4.12.2
[cli][debug] urllib3: 2.2.2
[cli][debug] websocket-client: 1.8.0
[cli][debug] Arguments:
[cli][debug] url=https://www.bloomberg.com/live
[cli][debug] stream=['best']
[cli][debug] --loglevel=debug
[cli][debug] --webbrowser-executable=C:\Program Files\Google\Chrome\Application\chrome.exe
[cli][info] Found matching plugin bloomberg for URL https://www.bloomberg.com/live
[plugins.bloomberg][info] Could not find JSON data. Falling back to webbrowser API...
[webbrowser.webbrowser][info] Launching web browser: C:\Program Files\Google\Chrome\Application\chrome.exe (headless=False)
[webbrowser.webbrowser][debug] Waiting for web browser process to terminate
[plugins.bloomberg][error] Could not find JSON data. Invalid URL or bot protection...
error: No playable streams found on this URL: https://www.bloomberg.com/live |
|
Yes, I get the same issue. Bloomberg does not like the ip address of the vpn server I am using. See https://gist.github.com/DeltaEpsilon19498/b458c7a9b1d8745f4189391c61658438. |
bastimeyer
force-pushed
the
plugins/bloomberg/webbrowser
branch
from
d310fc1 to
fb0d4f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6075
Request the input URL using Streamlink's webbrowser API as a fallback mechanic, in case Bloomberg rejects the initial HTTP request being made using the regular HTTPSession. After successfully falling back to the webbrowser API, the user's IP address appears to be whitelisted, so subsequent requests can be made without having to use the webbrowser API.
Log output from yesterday when I fully replaced the initial HTTP request. It's now kept though and the webbrowser API is only used as a fallback.
@7k50, @DeltaEpsilon19498 please check... As said, they appear to whitelist your IP address for a certain amount of time when accessing their site regularly from your web browser. What I'm looking for is a debug log output where the fallback does work correctly. So please help me with this.
https://github.com/streamlink/streamlink/blob/master/CONTRIBUTING.md#pull-request-feedback