Skip to content

Network Remote V3 #1747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

poldi171254
Copy link

@poldi171254 poldi171254 commented May 18, 2025

I have now made the Network Remote optional and cleaned up the code as per request.
This replaces V2 pull request.
I tried to close my previous pull request, but can't find a way of doinng this

strawbsbot and others added 5 commits May 18, 2025 15:43
You need to restart Strawberry for this setting to take affect
Renamed classes to be less ambiguous

Save before clientmanager changes

This works after major change in clientmanager

Cleaned up formatting

Still works

I have fixed most of the code issues apart from the one I commented on where I wasn't sure what was meant or how to resolve the issue.
I reformatted all my code and used Qt stringliterals where applicable
Cmake now uses Qt Protobuf
I removed Application where I could. Still needed where I need acces to the player.
All objects should now be freed.
I have hardcoded the CMAKE_INSTALL_RPATH as RPATH seems to be a requirement when using Ninja as the cmake generator. Ubuntu currently comes with 6.4.2, but the QtCreator is on 6.8 I'm pulling in the library from the Creator

Not sure what you meant by "I think we should use signals/slots to reload settings (like most other places) instead of the singleton"
Not sure what the Copyright header should look like. Do I put my name on this?
I have not made the Network remote optional yet as I wanted to get the code sorted out first

I still have have one outstanding issue on Ubuntu
[1276/1276 11.5/sec] Linking CXX executable strawberry
/usr/bin/ld: warning: libicui18n.so.73, needed by /home/llist/Qt/6.8.2/gcc_64/lib/libQt6Core.so.6.8.2, may conflict with libicui18n.so.74
/usr/bin/ld: warning: libicuuc.so.73, needed by /home/llist/Qt/6.8.2/gcc_64/lib/libQt6Core.so.6.8.2, may conflict with libicuuc.so.74

Changes requested by maintainer

Added Copyright

Passing Player instead of Application as an argument

Clean code as per maintainers request
Using Player rather than Application class to get song data

Code cleanup

Removed RPATH related entries form cmake file
Fixed code as per maintainers reuqest
Removed all non essential refererences to a Application from the code
Inserted Copyright

Stage 1 of making Network Remote optional
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants