Use the coverArt field from song JSON if available #1731
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR make sure that the coverArt JSON field in the subsonic song API takes precedence over the album or song ID.
As I understand it, if a song has a coverArt field then that one is the one to be used. As a fallback solution strawberry uses the song id. However if the setting "Use Album ID for album covers" is set, then the coverArt is ignored.
I have tried with the lms (https://github.com/epoupon/lms/tree/master) server and causes many errors since the album id is not mapped to the cover id (i.e., the only option for the getCoverArt method is to give the cover id).
My interpretation is that the "Use Album ID for album covers" uses album id as a fallback solution when the coverArt is not found in the song. If false, then the song id will be used as a fallback solution. That's the logic that this PR implements.
Thanks!