Skip to content

Repatch electron builder custom optimizations #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 20, 2025

Conversation

xyloflake
Copy link
Collaborator

Repatching #171 and #173 for app-builder-lib v26.0.7.

Note

I'm not repatching pacman autoupdates (#192) because my pr was merged in electron builder.

@xyloflake xyloflake self-assigned this Feb 20, 2025
@xyloflake xyloflake enabled auto-merge (squash) February 20, 2025 08:42
@xyloflake
Copy link
Collaborator Author

In the near future I'll make an autopatcher so that I don't have to manually repatch for every dependency update.

@xyloflake
Copy link
Collaborator Author

All done. Ready to be merged. Please test builds (and their sizes) to confirm it's working. I'm gonna run a ci action to make sure it's building well.

@xyloflake
Copy link
Collaborator Author

Ahhhh, I just remembered I have to repatch the about window thing on linux as well.

@xyloflake
Copy link
Collaborator Author

Just realised #188 didn't have any patches to electron-builder itself. It looks like there have been some changes that detect "Action" is not valid. I will have to look into this.

@xyloflake xyloflake merged commit 8fd0177 into main Feb 20, 2025
0 of 3 checks passed
@xyloflake xyloflake deleted the origin/electron-builder-patches branch February 20, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants