Stricter Ractor.make_shareable checking for TYPEDDATA
#15511
+15
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
luke-gruber
force-pushed
the
ractor_make_shareable_typeddata
branch
from
2037ff3 to
5a15954
Compare
While working on ractor-local tracepoints, I noticed you could make `TracePoint` objects ractor-shareable with `Ractor.make_shareable`. This shouldn't be the case because this typed data type doesn't have the `RUBY_TYPED_FROZEN_SHAREABLE` flag set. Now we check for typed data objects first, then traverse if it's allowed.
luke-gruber
force-pushed
the
ractor_make_shareable_typeddata
branch
from
5a15954 to
c0e2def
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on ractor-local tracepoints, I noticed you could make
TracePointobjects ractor-shareable withRactor.make_shareable. This shouldn't be the case because this typed data type doesn't have theRUBY_TYPED_FROZEN_SHAREABLEflag set.Now we check for typed data objects first, then traverse if it's allowed.