-
Notifications
You must be signed in to change notification settings - Fork 159
[DRAFT] implementation for pivot row limit #8492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I have created a proper Notion PRD here: |
| {#if !isFlat} | ||
| <Tooltip location="bottom" alignment="start" distance={8}> | ||
| <div class="row-limit-dropdown pointer-events-auto"> | ||
| <span class="row-limit-label">Row limit</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it has the wrong font size and color
| placeholder="Row limit" | ||
| /> | ||
| </div> | ||
| <TooltipContent slot="tooltip-content"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tooltip should anchor on the label and not the dropdown as it would overlap the first dropdown option
|
When navigating from Pivot -> Explore -> Pivot we lose the limit setting |
|
several issues with expanded rows and limits:
|
|
It seems export is broken, it does no longer sort on the measure |
|
totals are not respecting limits |
Notion PRD here. The Notion PRD should serve as the source of truth for this feature.
https://www.notion.so/rilldata/Pivot-row-limit-for-nested-dimensions-2c7ba33c8f5780ff8ddfdd9fd94cfeda?source=copy_link
Add row limit control to pivot tables
This PR adds a configurable row limit feature to pivot tables, allowing users to control how many child rows are displayed under each dimension.
Changes
UI Components:
State Management:
rowLimit?: numberfield toPivotState(undefined = unlimited)setPivotRowLimitreducer that resets pagination, expanded state, and active cell when limit changesrow_limitparameterData Queries:
Checklist: