[dynamo] fix store attr graph break in with block #166036

williamwen42 · 2025-10-21T22:25:28Z

Stack from ghstack (oldest at bottom):

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela

Differential Revision: D85198055

[ghstack-poisoned]

pytorch-bot · 2025-10-21T22:25:32Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/166036

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

All Docker build failed due to Ubuntu archive outage

✅ No Failures

As of commit c49752c with merge base ad4dc52 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ghstack-source-id: 2d2f2b0 Pull Request resolved: #166036

williamwen42 · 2025-10-21T23:13:18Z

@williamwen42 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Lucaskabela · 2025-10-22T02:00:02Z

torch/_dynamo/symbolic_convert.py

        )
-        self.output.add_output_instructions([copy.copy(inst)])
+        inst_copy = copy.copy(inst)
+        inst_copy.exn_tab_entry = None


So this is the root fix (need to set exn_tab_entry to None) - can you provide a bit more context for me as to why this fixes the error? I am assuming it is because when this is set bytecode_transformation assumes certain things about the instr which isn't true

Before, we would add an instruction to the output code with an invalid exn_tab_entry (since it refers to the old set of instructions). This correction is done elsewhere in symbolic_convert.py - i.e.

pytorch/torch/_dynamo/symbolic_convert.py

Line 1019 in a988510

inst_copy.exn_tab_entry = None

Lucaskabela

Thanks for elaborating, lgtm

williamwen42 · 2025-10-27T18:44:08Z

@williamwen42 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

williamwen42 · 2025-10-27T18:44:57Z

@williamwen42 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

pytorchmergebot · 2025-10-28T04:46:28Z

Starting merge as part of PR stack under #166040

Fixes #166176 The error I attempted to fix in #162318 was still appearing internally. Surprised that this wasn't caught anywhere 😰 Pull Request resolved: #166040 Approved by: https://github.com/Lucaskabela ghstack dependencies: #166036

Lucaskabela · 2025-11-04T00:04:26Z

@pytorchbot cherry-pick --onto release/2.9 --fixes "error in new nested graphbreak feature (#166033)" -c bugfix

pytorch-bot · 2025-11-04T00:04:29Z

❌ 🤖 pytorchbot command failed:

@pytorchbot cherry-pick: error: argument -c/--classification: invalid choice: 'bugfix' (choose from 'regression', 'critical', 'fixnewfeature', 'docs', 'release')

usage: @pytorchbot cherry-pick --onto ONTO [--fixes FIXES] -c
                               {regression,critical,fixnewfeature,docs,release}

Try @pytorchbot --help for more info.

Lucaskabela · 2025-11-04T00:07:19Z

@pytorchbot cherry-pick --onto release/2.9 --fixes "error in new nested graphbreak feature (#166033)" -c fixnewfeature

pytorchbot · 2025-11-04T00:13:33Z

Cherry picking #166036

Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x ebb2b2e894a4ede8efc5f5fff068d4ac9972f77a returned non-zero exit code 1

Auto-merging test/dynamo/test_repros.py
CONFLICT (content): Merge conflict in test/dynamo/test_repros.py
Auto-merging torch/_dynamo/symbolic_convert.py
error: could not apply ebb2b2e894a... [dynamo] fix store attr graph break in with block (#166036)
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config set advice.mergeConflict false"

Details for Dev Infra team

Raised by workflow job

Lucaskabela · 2025-11-04T00:43:28Z

I will try to get this cherry-pick request tomorrow

Fixes #166033 Differential Revision: [D85198055](https://our.internmc.facebook.com/intern/diff/D85198055) Pull Request resolved: #166036 Approved by: https://github.com/Lucaskabela (cherry picked from commit ebb2b2e)

Fixes #166176 The error I attempted to fix in #162318 was still appearing internally. Surprised that this wasn't caught anywhere 😰 Pull Request resolved: #166040 Approved by: https://github.com/Lucaskabela ghstack dependencies: #166036 (cherry picked from commit 32fe4f6)

* [dynamo] fix store attr graph break in with block (#166036) Fixes #166033 Differential Revision: [D85198055](https://our.internmc.facebook.com/intern/diff/D85198055) Pull Request resolved: #166036 Approved by: https://github.com/Lucaskabela (cherry picked from commit ebb2b2e) * [dynamo] fix keyerror in resume_execution (again) (#166040) Fixes #166176 The error I attempted to fix in #162318 was still appearing internally. Surprised that this wasn't caught anywhere 😰 Pull Request resolved: #166040 Approved by: https://github.com/Lucaskabela ghstack dependencies: #166036 (cherry picked from commit 32fe4f6) * fix self.current_instruction -> cur_tx.current_instruction --------- Co-authored-by: William Wen <[email protected]>

[dynamo] fix store attr graph break in with block

c49752c

[ghstack-poisoned]

pytorch-bot bot added ciflow/inductor module: dynamo labels Oct 21, 2025

williamwen42 added a commit that referenced this pull request Oct 21, 2025

[dynamo] fix store attr graph break in with block

af6cfa3

ghstack-source-id: 2d2f2b0 Pull Request resolved: #166036

williamwen42 added the topic: not user facing topic category label Oct 21, 2025

williamwen42 mentioned this pull request Oct 21, 2025

[dynamo] fix keyerror in resume_execution (again) #166040

Closed

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 21, 2025

Lucaskabela reviewed Oct 22, 2025

View reviewed changes

williamwen42 requested a review from Lucaskabela October 27, 2025 17:41

Lucaskabela approved these changes Oct 27, 2025

View reviewed changes

pytorchmergebot added the Merged label Oct 28, 2025

pytorchmergebot closed this in ebb2b2e Oct 28, 2025

Lucaskabela added this to the 2.9.1 milestone Nov 4, 2025

This was referenced Nov 4, 2025

[dynamo] fix keyerror in resume_execution, fix store attr #166924

Merged

[v2.9.1] Release Tracker #166758

Closed

atalman mentioned this pull request Nov 10, 2025

Release 2.9.1 validations checklist and cherry-picks #167476

Open

38 tasks

github-actions bot deleted the gh/williamwen42/317/head branch December 4, 2025 02:18

[dynamo] fix store attr graph break in with block #166036

[dynamo] fix store attr graph break in with block #166036

Uh oh!

Conversation

williamwen42 commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/166036

❗ 1 Active SEVs

✅ No Failures

Uh oh!

williamwen42 commented Oct 21, 2025

Uh oh!

Lucaskabela Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

williamwen42 Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

Lucaskabela left a comment

Choose a reason for hiding this comment

Uh oh!

williamwen42 commented Oct 27, 2025

Uh oh!

williamwen42 commented Oct 27, 2025

Uh oh!

pytorchmergebot commented Oct 28, 2025

Uh oh!

Lucaskabela commented Nov 4, 2025

Uh oh!

pytorch-bot bot commented Nov 4, 2025

Uh oh!

Lucaskabela commented Nov 4, 2025

Uh oh!

pytorchbot commented Nov 4, 2025

Cherry picking #166036

Uh oh!

Lucaskabela commented Nov 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

williamwen42 commented Oct 21, 2025 •

edited

Loading

pytorch-bot bot commented Oct 21, 2025 •

edited

Loading