-
Notifications
You must be signed in to change notification settings - Fork 26.2k
[BE] Update Python min version to 3.10 #162310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162310
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ⏳ No Failures, 90 PendingAs of commit 6fb0f08 with merge base 3a7db34 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
atalman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Thank you.
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
Skylion007
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll probably need to run ruff to run the pyupgrade rules FYI
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
|
@pytorchbot cherry-pick --onto release/2.9 --c critical --fixes #161167 |
Cherry picking #162310Command Details for Dev Infra teamRaised by workflow job |
This PR needs a
|
Pull Request resolved: #162310 Approved by: https://github.com/atalman, https://github.com/Skylion007, https://github.com/ZainRizvi ghstack dependencies: #162862
Pull Request resolved: #162310 Approved by: https://github.com/atalman, https://github.com/Skylion007, https://github.com/ZainRizvi ghstack dependencies: #162862 Co-authored-by: Nikita Shulga <[email protected]>
|
@pytorchbot cherry-pick --onto release/2.9 -c critical |
Cherry picking #162310Command Details for Dev Infra teamRaised by workflow job |
Pull Request resolved: #162310 Approved by: https://github.com/atalman, https://github.com/Skylion007, https://github.com/ZainRizvi
* [BE] Update Python min version to 3.10 (#162310) Pull Request resolved: #162310 Approved by: https://github.com/atalman, https://github.com/Skylion007, https://github.com/ZainRizvi * comment out executorch --------- Co-authored-by: Nikita Shulga <[email protected]>
Pull Request resolved: pytorch#162310 Approved by: https://github.com/atalman, https://github.com/Skylion007, https://github.com/ZainRizvi ghstack dependencies: pytorch#162862
This reverts commit 3016616. Reverted pytorch#162310 on behalf of https://github.com/malfet due to Breaks some windows tests ([comment](pytorch#162862 (comment)))
Pull Request resolved: pytorch#162310 Approved by: https://github.com/atalman, https://github.com/Skylion007, https://github.com/ZainRizvi
This reverts commit 9f5a644. Reverted pytorch#162310 on behalf of https://github.com/malfet due to Broke lint, but to the best of my knowledge it's no longer possible to run lint for all files on PRs ([comment](pytorch#162310 (comment)))
Pull Request resolved: pytorch#162310 Approved by: https://github.com/atalman, https://github.com/Skylion007, https://github.com/ZainRizvi
Since 2.9 release upstream set min Python version to 3.10 pytorch/pytorch#162310. We should align linters and scripts. Bumping linters also enables new lints, such as [B905](https://docs.astral.sh/ruff/rules/zip-without-explicit-strict/), which will not be fixed in this PR. This lint is xfailed in upstream too
Stack from ghstack (oldest at bottom):