Skip to content

[Dynamo] Don't guard data ptrs by default with mark_static_address #162208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mlazos wants to merge 1 commit into from
Closed

[Dynamo] Don't guard data ptrs by default with mark_static_address #162208

mlazos wants to merge 1 commit into from

Conversation

@mlazos
Copy link
Contributor

@mlazos mlazos commented Sep 4, 2025 •
edited by pytorch-bot bot
Loading

Fixes #156377

Since we now re-record cudagraphs, it's not necessary to guard by default anymore and induce a full recompile.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @Lucaskabela

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 4, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162208

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d14380c with merge base 69a25f6 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@mlazos mlazos added release notes: dynamo ciflow/trunk Trigger trunk jobs on your pull request labels Sep 4, 2025
@mlazos mlazos requested a review from anijain2305 September 4, 2025 21:34
@anijain2305
Copy link
Contributor

anijain2305 commented Sep 8, 2025

Test failing. Good to go from my side after the branch cut (which should be today).

@mlazos mlazos force-pushed the mlazos/mark-static-update branch from 898acf4 to d14380c Compare September 11, 2025 17:50
@anijain2305 anijain2305 added the topic: bc breaking topic category label Sep 11, 2025
@pytorch pytorch deleted a comment from pytorchmergebot Sep 11, 2025
@mlazos mlazos requested a review from ezyang September 11, 2025 20:15
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 11, 2025

@mlazos has imported this pull request. If you are a Meta employee, you can view this in D82249747.

@mlazos
Copy link
Contributor Author

mlazos commented Sep 11, 2025 •
edited
Loading

From Ed:
Check that this doesn't break fbcode (importing now and checking)

Does this cause silent incorrectness if the user uses it with the old default arg:
No this doesn't because it will just cause cudagraphs to re-record.

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 11, 2025

Merge failed

Reason: Comment with id 3282184494 not found

Details for Dev Infra team Raised by workflow job

@ezyang
Copy link
Contributor

ezyang commented Sep 12, 2025

Reviewing the PR this looks relatively safe

@mlazos
Copy link
Contributor Author

mlazos commented Sep 12, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 12, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@mlazos @markc-614
[Dynamo] Don't guard data ptrs by default with mark_static_address (p…
156435f 
…ytorch#162208)

Fixes pytorch#156377

Since we now re-record cudagraphs, it's not necessary to guard by default anymore and induce a full recompile.

Pull Request resolved: pytorch#162208
Approved by: https://github.com/anijain2305
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@mlazos @mansiag05
[Dynamo] Don't guard data ptrs by default with mark_static_address (p…
bc6499f 
…ytorch#162208)

Fixes pytorch#156377

Since we now re-record cudagraphs, it's not necessary to guard by default anymore and induce a full recompile.

Pull Request resolved: pytorch#162208
Approved by: https://github.com/anijain2305
cleonard530 pushed a commit to cleonard530/pytorch that referenced this pull request Sep 22, 2025
@mlazos @cleonard530
[Dynamo] Don't guard data ptrs by default with mark_static_address (p…
9138a15 
…ytorch#162208)

Fixes pytorch#156377

Since we now re-record cudagraphs, it's not necessary to guard by default anymore and induce a full recompile.

Pull Request resolved: pytorch#162208
Approved by: https://github.com/anijain2305
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@mlazos @dsashidh
[Dynamo] Don't guard data ptrs by default with mark_static_address (p…
b221213 
…ytorch#162208)

Fixes pytorch#156377

Since we now re-record cudagraphs, it's not necessary to guard by default anymore and induce a full recompile.

Pull Request resolved: pytorch#162208
Approved by: https://github.com/anijain2305
@github-actions github-actions bot deleted the mlazos/mark-static-update branch October 13, 2025 02:15
hoshibara pushed a commit to hoshibara/pytorch that referenced this pull request Oct 22, 2025
@mlazos @hoshibara
[Dynamo] Don't guard data ptrs by default with mark_static_address (p…
3bbf743 
…ytorch#162208)

Fixes pytorch#156377

Since we now re-record cudagraphs, it's not necessary to guard by default anymore and induce a full recompile.

Pull Request resolved: pytorch#162208
Approved by: https://github.com/anijain2305
@Lucaskabela Lucaskabela linked an issue Nov 3, 2025 that may be closed by this pull request
[Inductor][AO] Flex Attention with AO hit the recompile limit on v2.9.0 #166153
Closed
@Lucaskabela
Copy link
Contributor

Lucaskabela commented Nov 4, 2025

@pytorchbot cherry-pick --onto release/2.9 --fixes "recompilation limit (including on flexAttention - #166153)" -c regression

pytorchbot pushed a commit that referenced this pull request Nov 4, 2025
@mlazos @pytorchbot
[Dynamo] Don't guard data ptrs by default with mark_static_address (#…
14f5d07 
…162208)

Fixes #156377

Since we now re-record cudagraphs, it's not necessary to guard by default anymore and induce a full recompile.

Pull Request resolved: #162208
Approved by: https://github.com/anijain2305

(cherry picked from commit 75de5b6)
@pytorchbot
Copy link
Collaborator

pytorchbot commented Nov 4, 2025

Cherry picking #162208

The cherry pick PR is at #166913 and it is linked with issue recompilation limit (including on flexAttention - #166153). The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

@pytorchbot pytorchbot mentioned this pull request Nov 4, 2025
Closed
atalman pushed a commit that referenced this pull request Nov 5, 2025
@pytorchbot @mlazos
[Dynamo] Don't guard data ptrs by default with mark_static_address (#…
76335d8 
…166913)

[Dynamo] Don't guard data ptrs by default with mark_static_address (#162208)

Fixes #156377

Since we now re-record cudagraphs, it's not necessary to guard by default anymore and induce a full recompile.

Pull Request resolved: #162208
Approved by: https://github.com/anijain2305

(cherry picked from commit 75de5b6)

Co-authored-by: Michael Lazos <[email protected]>
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 15, 2025

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: argument command: invalid choice: 'backport' (choose from 'merge', 'revert', 'rebase', 'label', 'drci', 'cherry-pick')

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci,cherry-pick} ...

Try @pytorchbot --help for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anijain2305 anijain2305 anijain2305 approved these changes

@ezyang ezyang Awaiting requested review from ezyang

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo module: inductor release notes: dynamo topic: bc breaking topic category

Projects

None yet

Milestone

No milestone

8 participants

@mlazos @anijain2305 @facebook-github-bot @pytorchmergebot @ezyang @Lucaskabela @pytorchbot