Skip to content

Fix return type of classmethod parse #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tomschr merged 2 commits into from
Feb 28, 2023
Merged

Fix return type of classmethod parse #396

tomschr merged 2 commits into from
Feb 28, 2023

Conversation

@def-
Copy link
Contributor

@def- def- commented Feb 27, 2023

So that calling parse on a derived class will show correct type of derived class

def- and others added 2 commits February 27, 2023 22:28
@def-
Fix return type of classmethod parse
35d3f9a 
So that calling parse on a derived class will show correct type of
derived class
@tomschr
Move T definition some lines up
38bc78f
@tomschr
Copy link
Member

tomschr commented Feb 28, 2023

Thank you very much @def-! 👍
I'm not so familiar with type hints, so this is very helpful.

The only minor change that I did was to move the line with T = TypeVar("T", bound="Version") up so all definitions are together.

Many thanks!

@tomschr tomschr merged commit 6176316 into python-semver:master Feb 28, 2023
@tomschr tomschr added Release_3.x.y Only for the major release 3 Bug Error, flaw or fault to produce incorrect or unexpected results labels Feb 28, 2023
tomschr added a commit that referenced this pull request Feb 28, 2023
@tomschr
Add changelog entry for PR #396
bee273e
@def- def- deleted the pr-cls-type branch February 28, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Bug Error, flaw or fault to produce incorrect or unexpected results Release_3.x.y Only for the major release 3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@def- @tomschr