Fix #236: add missing deprecated functions #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecate: * `semver.compare` -> `semver.VersionInfo.compare` * `semver.match` -> `semver.VersionInfo.match` Change: * Implementation of `semver.max_ver` and `semver.min_ver`
Member
Author
|
I've found out a method to get rid of For example, rewriting the def __eq__(self, other):
return self.compare(other) == 0IMHO this is much nicer than the original one: def __eq__(self, other):
return _compare_by_keys(self.to_dict(), _to_dict(other)) == 0The above method makes the The See commit 4482f8c. Maybe this change should go into another, separate PR? |
* Call self.compare(other) in all comparison operators. * Make sure, "other" is a compatible type (VersionInfo, dict, list, tuple, or string)
Member
Author
|
If nobody objects, I would merge it tomorrow. 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #236 and contains the following changes:
Deprecate:
semver.compare->semver.VersionInfo.comparesemver.match->semver.VersionInfo.matchChange:
semver.max_verandsemver.min_verThe implementation in this PR is a minimal implementation. I could have done more, butI would like to hear your opinion. I have two questions:Should we really move the functions
semver.max_verandsemver.min_verinto the class? Especially if we maybe want to change them later, see Deprecate min_ver/max_ver and use builtin max()/min() functions #160.What about the "private" functions
_nat_cmpand? Should we move them into the class as well._compare_by_keys@python-semver/reviewers What do you think?