Storekit problems #224
Merged
Storekit problems #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
There was a problem hiding this comment.
Pull Request Overview
This PR addresses StoreKit error handling and UI message consistency while cleaning up unused entitlements and duplicate project entries.
- Introduces a getStoreKitErrorMessage utility function to format StoreKit errors.
- Updates error messages and text alignment in UI views for consistency.
- Removes deprecated entitlement exceptions and duplicate storekit references in the project configuration.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| BrightIntosh/Utils.swift | Adds a utility function for formatting StoreKit error messages. |
| BrightIntosh/UI/SettingsWindow.swift | Adjusts the text frame alignment within the settings sheet. |
| BrightIntosh/UI/BrightIntoshStore.swift | Updates error handling and UI messages for store operations. |
| BrightIntosh/Localizable.xcstrings | Corrects translation strings to reflect updated UI messages. |
| BrightIntosh/BrightIntosh.entitlements | Removes temporary entitlement exceptions. |
| BrightIntosh.xcodeproj/project.pbxproj | Eliminates duplicate storekit build file references. |
niklasr22
force-pushed
the
storekit-problems
branch
from
07010a0 to
9b11278
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR improves StoreKit error handling, refines UI alignment, corrects user-facing text, and cleans up project resources and entitlements.
- Introduced
getStoreKitErrorMessageand updated catch blocks to use it - Adjusted view alignments and fixed grammar in localized strings
- Removed unused entitlements and cleaned up resource references in project file
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| BrightIntosh/Utils.swift | Added getStoreKitErrorMessage helper to standardize detailed StoreKit error messages |
| BrightIntosh/UI/SettingsWindow.swift | Set text frame alignment to leading |
| BrightIntosh/UI/BrightIntoshStore.swift | Enhanced catch blocks for StoreKitError, removed obsolete productLoadingFailed state |
| BrightIntosh/Localizable.xcstrings | Corrected grammar in localization entries and removed strings no longer used by the code |
| BrightIntosh/BrightIntosh.entitlements | Removed temporary sandbox exception for mach-lookup |
| BrightIntosh.xcodeproj/project.pbxproj | Cleaned up duplicate and outdated resource build file entries (Products.storekit, cli.sh) |
Comments suppressed due to low confidence (2)
BrightIntosh/BrightIntosh.entitlements:2
- [nitpick] Temporary sandbox exceptions for mach-lookup were removed; verify that no IPC or helper services rely on these entitlements and update documentation or entitlement tests accordingly.
<key>com.apple.security.temporary-exception.mach-lookup.global-name</key>
BrightIntosh.xcodeproj/project.pbxproj:15
- There appears to be a duplicate
cli.shresource entry, which can cause build inconsistencies. Remove the redundant PBXBuildFile reference.
+ 9C17DFB02DD1F3DA00185CDA /* cli.sh in Resources */ = {isa = PBXBuildFile; fileRef = 9C17DFAD2DD0CA3200185CDA /* cli.sh */; };
2de50b4 to
cd55219
Compare
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
painful stuff
more details for error messages to help finding the cause of #223