Send node info when node is switched to ephemeral #21456
Draft
+61
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds completion synchronization support to ACLK queries to ensure node information is fully transmitted to the cloud before proceeding with ephemeral node cleanup operations. This prevents race conditions where a node might be unregistered before the cloud receives its final state update.
Key changes:
- Added completion pointer field to aclk_query_t structure to track query completion
- Introduced
send_node_info_with_wait()andsend_node_update_with_wait()helper functions for synchronous ACLK operations - Updated
aclk_host_state_update()andaclk_update_node_info()signatures to accept completion parameters
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/database/sqlite/sqlite_aclk_node.h | Declares new helper functions for waiting on node info/state updates |
| src/database/sqlite/sqlite_aclk_node.c | Implements wait helpers and updates build_node_info to accept completion parameter |
| src/daemon/service.c | Uses new wait functions during orphan host cleanup to ensure cloud sync before unregistration |
| src/daemon/commands.c | Uses new wait functions in CLI commands for marking nodes ephemeral |
| src/aclk/aclk_query_queue.h | Adds completion field to aclk_query_t structure |
| src/aclk/aclk_query_queue.c | Marks completion as complete when freeing queries |
| src/aclk/aclk_contexts_api.h | Updates aclk_update_node_info signature to accept completion parameter |
| src/aclk/aclk_contexts_api.c | Passes completion to query for node info updates |
| src/aclk/aclk.h | Updates aclk_host_state_update signature to accept completion parameter |
| src/aclk/aclk.c | Propagates completion through node state update call chain |
Comments suppressed due to low confidence (1)
src/aclk/aclk_contexts_api.c:41
- If payload generation fails (line 39 returns NULL), the QUEUE_IF_PAYLOAD_PRESENT macro will call aclk_query_free(query) which will mark the completion as complete. However, this means the completion will be marked complete even though the node info was never actually sent. Callers of send_node_info_with_wait expect the wait to indicate successful transmission, but this completion will be marked on failure too. Consider either propagating the error to the caller or documenting this behavior clearly.
void aclk_update_node_info(struct update_node_info *info, struct completion *compl)
{
aclk_query_t *query = aclk_query_new(UPDATE_NODE_INFO);
query->completion = compl;
query->data.bin_payload.topic = ACLK_TOPICID_NODE_INFO;
query->data.bin_payload.payload = generate_update_node_info_message(&query->data.bin_payload.size, info);
query->data.bin_payload.msg_name = "UpdateNodeInfo";
QUEUE_IF_PAYLOAD_PRESENT(query);
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
stelfrag
force-pushed
the
submit_node_info
branch
from
fe3a80a to
5bd1982
Compare
…djust syntax inconsistencies
stelfrag
force-pushed
the
submit_node_info
branch
from
5bd1982 to
717646a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
netdatacli remove-stale_nodenetdatacli mark-stale-nodes-ephemeralSummary by cubic
Send full node info to Cloud when a node is marked ephemeral, and wait for the update to finish before unregistering. This ensures Cloud has accurate data and avoids race conditions during ephemeral cleanup.
New Features
Refactors
Written for commit 717646a. Summary will update automatically on new commits.